Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/e2e: restart Envoy pods in between tests #6247

Closed
wants to merge 1 commit into from
Closed

test/e2e: restart Envoy pods in between tests #6247

wants to merge 1 commit into from

Conversation

skriss
Copy link
Member

@skriss skriss commented Mar 5, 2024

This allows each test to run with a "clean" set of Envoys that haven't been configured with resources from previous tests.

@skriss
test/e2e: restart Envoy pods in between tests
6ceab85 
This allows each test to run with a "clean" set of
Envoys that haven't been configured with resources
from previous tests.

Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
@skriss skriss added the release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. label Mar 5, 2024
@skriss skriss requested a review from a team as a code owner March 5, 2024 19:44
@skriss skriss requested review from tsaarni and sunjayBhatia and removed request for a team March 5, 2024 19:44
@skriss
Copy link
Member Author

skriss commented Mar 5, 2024

xref #6244 (comment)

@projectcontour/maintainers any reason not to do this?

@sunjayBhatia sunjayBhatia requested review from a team, izturn and clayton-gonsalves and removed request for a team March 5, 2024 19:45
@skriss
Copy link
Member Author

skriss commented Mar 6, 2024

Closing this out, after review it shouldn't be necessary and actually the current behavior provides some useful implicit coverage around control plane reconnects.

@skriss skriss closed this Mar 6, 2024
@skriss skriss deleted the pr-e2e-restart-envoy branch March 12, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsaarni tsaarni Awaiting requested review from tsaarni tsaarni is a code owner automatically assigned from projectcontour/maintainers

@sunjayBhatia sunjayBhatia Awaiting requested review from sunjayBhatia sunjayBhatia is a code owner automatically assigned from projectcontour/maintainers

@izturn izturn Awaiting requested review from izturn izturn was automatically assigned from projectcontour/contour-reviewers

@clayton-gonsalves clayton-gonsalves Awaiting requested review from clayton-gonsalves clayton-gonsalves was automatically assigned from projectcontour/contour-reviewers

Assignees
No one assigned
Labels
release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@skriss