Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Envoy removing TE request header #6288

Conversation

sunjayBhatia
Copy link
Member

Removal of the header was added by default in Envoy v1.29.0. This change reverts back to prior behavior.

This change can be reverted once envoyproxy/envoy#32255 is backported or present in a new release of Envoy.

Removal of the header was added by default in Envoy v1.29.0.
This change reverts back to prior behavior.

This change can be reverted once envoyproxy/envoy#32255 is
backported or present in a new release of Envoy.

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@sunjayBhatia sunjayBhatia added the release-note/minor A minor change that needs about a paragraph of explanation in the release notes. label Mar 18, 2024
@sunjayBhatia sunjayBhatia requested a review from a team as a code owner March 18, 2024 20:11
@sunjayBhatia sunjayBhatia requested review from tsaarni, skriss, a team, davinci26 and clayton-gonsalves and removed request for a team March 18, 2024 20:11
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.56%. Comparing base (484c407) to head (5ecd204).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6288   +/-   ##
=======================================
  Coverage   81.56%   81.56%           
=======================================
  Files         133      133           
  Lines       15800    15801    +1     
=======================================
+ Hits        12887    12888    +1     
  Misses       2617     2617           
  Partials      296      296           
Files Coverage Δ
internal/envoy/v3/runtime.go 100.00% <100.00%> (ø)

Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
@sunjayBhatia sunjayBhatia enabled auto-merge (squash) March 18, 2024 22:13
@sunjayBhatia sunjayBhatia merged commit 774fae8 into projectcontour:main Mar 18, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/minor A minor change that needs about a paragraph of explanation in the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants