Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Circuit breaker statistics for tracking remaining #6297

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

rajatvig
Copy link
Member

@rajatvig rajatvig commented Mar 23, 2024

Added support for enabling circuit breaker statistics tracking.

Fixes #5794

Signed-off-by: Rajat Vig rvig@etsy.com

Added support for enabling circuit breaker statistics tracking.

Fixes 5794

Signed-off-by: Rajat Vig <rvig@etsy.com>
@rajatvig rajatvig requested a review from a team as a code owner March 23, 2024 02:05
@rajatvig rajatvig requested review from skriss and sunjayBhatia and removed request for a team March 23, 2024 02:05
@sunjayBhatia sunjayBhatia requested review from a team, davinci26 and clayton-gonsalves and removed request for a team March 23, 2024 02:05
@rajatvig rajatvig added the release-note/minor A minor change that needs about a paragraph of explanation in the release notes. label Mar 23, 2024
Signed-off-by: Rajat Vig <rvig@etsy.com>
@rajatvig rajatvig added release-note/small A small change that needs one line of explanation in the release notes. and removed release-note/minor A minor change that needs about a paragraph of explanation in the release notes. labels Mar 23, 2024
Copy link

codecov bot commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.56%. Comparing base (5f1b981) to head (14592d1).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6297   +/-   ##
=======================================
  Coverage   81.56%   81.56%           
=======================================
  Files         133      133           
  Lines       15801    15805    +4     
=======================================
+ Hits        12888    12892    +4     
  Misses       2617     2617           
  Partials      296      296           
Files Coverage Δ
internal/envoy/v3/bootstrap.go 94.27% <100.00%> (+0.03%) ⬆️
internal/envoy/v3/cluster.go 96.36% <100.00%> (+0.03%) ⬆️

@rajatvig
Copy link
Member Author

rajatvig commented Apr 3, 2024

@sunjayBhatia When you have time, could you please look at the PR?

Copy link
Contributor

@lubronzhan lubronzhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @rajatvig

@skriss skriss merged commit 6bdda0b into projectcontour:main Apr 11, 2024
26 checks passed
@rajatvig rajatvig deleted the EnableCBStatistics branch April 17, 2024 09:34
SamMHD pushed a commit to SamMHD/contour that referenced this pull request Sep 8, 2024
…our#6297)

Added support for enabling circuit breaker statistics tracking.

Fixes 5794

Signed-off-by: Rajat Vig <rvig@etsy.com>
Signed-off-by: Saman Mahdanian <saman@mahdanian.xyz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/small A small change that needs one line of explanation in the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable statistics for remaining_ in Envoy
3 participants