Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: http buffer filter configuration (#6249) #6315

Closed
wants to merge 4 commits into from

use config param instead of cli args

fba7631
Select commit
Loading
Failed to load commit list.
Closed

feature: http buffer filter configuration (#6249) #6315

use config param instead of cli args
fba7631
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 27, 2024 in 1s

81.57% (+0.00%) compared to c3d6cb4

View this Pull Request on Codecov

81.57% (+0.00%) compared to c3d6cb4

Details

Codecov Report

Attention: Patch coverage is 94.11765% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.57%. Comparing base (c3d6cb4) to head (fba7631).
Report is 90 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6315   +/-   ##
=======================================
  Coverage   81.56%   81.57%           
=======================================
  Files         133      134    +1     
  Lines       15801    15828   +27     
=======================================
+ Hits        12888    12911   +23     
- Misses       2617     2621    +4     
  Partials      296      296           
Files Coverage Δ
cmd/contour/servecontext.go 86.02% <100.00%> (+0.07%) ⬆️
internal/contourconfig/contourconfiguration.go 98.70% <100.00%> (+0.01%) ⬆️
internal/envoy/v3/buffer.go 100.00% <100.00%> (ø)
internal/xdscache/v3/listener.go 92.06% <100.00%> (+0.05%) ⬆️
pkg/config/parameters.go 88.07% <100.00%> (+0.04%) ⬆️
cmd/contour/serve.go 22.59% <0.00%> (-0.07%) ⬇️

... and 5 files with indirect coverage changes