bump Envoy to v1.29.3 #6328
Merged
bump Envoy to v1.29.3 #6328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removes setting the envoy.reloadable_features.sanitize_te runtime flag to false since Envoy's behavior is now correct. Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
skriss
added
the
release-note/small
skriss
requested review from
tsaarni and
sunjayBhatia
and removed request for
a team
sunjayBhatia
requested review from
a team,
rajatvig and
clayton-gonsalves
and removed request for
a team
skriss
commented
Apr 9, 2024
Comment on lines
-43
to
-47
| // Disable Envoy removing the client TE request header. Removing | ||
| // the header was added by default in Envoy v1.29.0. | ||
| // Can remove once https://github.com/envoyproxy/envoy/pull/32255 is | ||
| // backported or present in a new release of Envoy. | ||
| "envoy.reloadable_features.sanitize_te": structpb.NewBoolValue(false), |
There was a problem hiding this comment.
I am thinking that we should leave this set to false in the Contour 1.28 backport, since our documented upgrade procedure upgrades the control plane before the data plane; however, removed it here in main, since before users upgrade to Contour 1.29 they should be on a version of Contour/Envoy which has the correct behavior even without the runtime flag.
There was a problem hiding this comment.
yep that sounds like a good plan 👍🏽
There was a problem hiding this comment.
Yes. It would be nice to have it in place as it is. Longer term, could we plan on allowing end users to change them?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6328 +/- ##
==========================================
- Coverage 81.56% 81.56% -0.01%
==========================================
Files 133 133
Lines 15802 15801 -1
==========================================
- Hits 12889 12888 -1
Misses 2617 2617
Partials 296 296
|
sunjayBhatia
approved these changes
Apr 9, 2024
skriss
added a commit
to skriss/contour
that referenced
this pull request
May 2, 2024
Changelog projectcontour#6328 was superceded by projectcontour#6353. Signed-off-by: Steve Kriss <stephen.kriss@gmail.com>
skriss
added a commit
that referenced
this pull request
May 2, 2024
SamMHD
pushed a commit
to SamMHD/contour
that referenced
this pull request
Sep 8, 2024
Also removes setting the envoy.reloadable_features.sanitize_te runtime flag to false since Envoy's behavior is now correct. Signed-off-by: Steve Kriss <stephen.kriss@gmail.com> Signed-off-by: Saman Mahdanian <saman@mahdanian.xyz>
SamMHD
pushed a commit
to SamMHD/contour
that referenced
this pull request
Sep 8, 2024
Changelog projectcontour#6328 was superceded by projectcontour#6353. Signed-off-by: Steve Kriss <stephen.kriss@gmail.com> Signed-off-by: Saman Mahdanian <saman@mahdanian.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes setting the envoy.reloadable_features.sanitize_te runtime flag to false since Envoy's behavior is now correct.