internal/envoy: support AuthPolicy on direct response routes #6426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, auth policies on direct response routes were ignored. Signed-off-by: Steve Kriss <stephen.kriss@gmail.com> Co-authored-by: shadi-altarsha <shadi.altarsha@reddit.com>
skriss
added
the
release-note/none-required
skriss
requested review from
tsaarni and
sunjayBhatia
and removed request for
a team
sunjayBhatia
requested review from
a team,
rajatvig and
izturn
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6426 +/- ##
=======================================
Coverage 81.62% 81.63%
=======================================
Files 133 133
Lines 15857 15862 +5
=======================================
+ Hits 12944 12949 +5
Misses 2619 2619
Partials 294 294
|
sunjayBhatia
reviewed
May 8, 2024
| {Prefix: "/direct-response-auth-enabled"}, | ||
| }, | ||
| DirectResponsePolicy: &contour_v1.HTTPDirectResponsePolicy{ | ||
| StatusCode: http.StatusTeapot, |
sunjayBhatia
approved these changes
May 8, 2024
SamMHD
pushed a commit
to SamMHD/contour
that referenced
this pull request
Sep 8, 2024
…contour#6426) Previously, auth policies on direct response routes were ignored. Signed-off-by: Steve Kriss <stephen.kriss@gmail.com> Co-authored-by: shadi-altarsha <shadi.altarsha@reddit.com> Signed-off-by: Saman Mahdanian <saman@mahdanian.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, auth policies on direct response routes were ignored.
Based on #5962, included just the ExtAuth changes (will look at global rate limit E2E additions separately) and added routes/test cases to the existing ExtAuth E2E for simplicity.