Add/max connections to accept param #7292
Open
+2,938
−896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimiyasharifi
requested review from
sunjayBhatia and
tsaarni
and removed request for
a team
sunjayBhatia
requested review from
a team,
izturn and
rajatvig
and removed request for
a team
|
Hi @kimiyasharifi! Welcome to our community and thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Contour better. You can also join us on our mailing list and in our channel in the Kubernetes Slack Workspace |
…alue MaxConnectionsToAcceptPerSocketEvent is a *wrapperspb.UInt32Value in EnvoyListenerConfig, so wrap the uint32 value using wrapperspb.UInt32() to fix the type mismatch and prevent compilation errors.
kimiyasharifi
force-pushed
the
add/max-connections-to-accept-param
branch
from
4cbba23 to
4ebb517
Compare
sunjayBhatia
requested changes
Nov 17, 2025
Member
sunjayBhatia
left a comment
sunjayBhatia
left a comment
There was a problem hiding this comment.
This PR looks like it currently includes unrelated changes to the title/description and deletes the existing github workflow files
To get this in we'll need some cleanup on the diff to only include relevant changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MaxConnectionsToAcceptPerSocketEvent to EnvoyListenerConfig