Fix bug in tutorial to calculate MRS with potential trade #33
Conversation
|
I think we should set |
|
Made calculate_MRS so it requires sugar and spice. I also increased the number of runs since the memory issue is mitigated. |
| @@ -187,6 +187,13 @@ def step(self): | |||
|
|
|||
| # collect model level data | |||
| self.datacollector.collect(self) | |||
| # Need to remove excess data | |||
| # Create local variable to store trade data | |||
There was a problem hiding this comment.
What about projectmesa/mesa#1419 (comment) ? Which doesn't expose the internal wiring of the DataCollector.
There was a problem hiding this comment.
My concern with putting it in the model collector is the point of the lesson is to talk about the agent reporter. Showing the internal wiring of datacollector, I think is more consistent with the learning objectives as I show the source code in various lessons.. This leads back to your second comment that we would need to build a class for collecting DataCollectorRABT.
So in I would prefer to show the internal wiring... I don't know.. what do you think?
There was a problem hiding this comment.
I suppose it is fine for now as long as there is a comment that says this part is still a work in progress, with a link to #1419.
|
Needs Black formatting, |
Done |
|
There are still trailing whitespaces in examples/sugarscape_g1mt/sugarscape_g1mt/model.py. |
- update maybe_sell_spice() so calculate_MRS() takes potential sugar and spice based on trade - update calculate_MRS() with kwargs so it can take potential trade but defaults to agents sugar and spice Update increases agent_reporter due to number of trades creating memory issues - Update data collection so non-relevant data rmeoved on each step (i.e. sugar and spice agents don't have trade partners)
Sorry about that forget to install pre-commit in my mesa-examples. |
|
LGTM |
…a#33) - update maybe_sell_spice() so calculate_MRS() takes potential sugar and spice based on trade - update calculate_MRS() with kwargs so it can take potential trade but defaults to agents sugar and spice Update increases agent_reporter due to number of trades creating memory issues - Update data collection so non-relevant data rmeoved on each step (i.e. sugar and spice agents don't have trade partners)
- update maybe_sell_spice() so calculate_MRS() takes potential sugar and spice based on trade - update calculate_MRS() with kwargs so it can take potential trade but defaults to agents sugar and spice Update increases agent_reporter due to number of trades creating memory issues - Update data collection so non-relevant data rmeoved on each step (i.e. sugar and spice agents don't have trade partners)
Update increases agent_reporter due to number of trades creating memory issues