Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sugarscape G1MT: Remove redundant schedule steps increment #92

Closed
wants to merge 1 commit into from

Conversation

rht
Copy link
Contributor

@rht rht commented Jan 24, 2024

No description provided.

@rht
Copy link
Contributor Author

rht commented Jan 24, 2024

cc: @tpike3

@EwoutH
Copy link
Member

EwoutH commented Jan 24, 2024

Could you add a brief description what changed exactly that this isn't needed anymore? That helps to place it in context.

@rht
Copy link
Contributor Author

rht commented Jan 24, 2024

This is a long-standing bug. The RandomActivationByType already has https://github.com/projectmesa/mesa/blob/c0c8479e4d1f29c20ee2a32caeb6a3eaa1682041/mesa/time.py#L363.

@rht
Copy link
Contributor Author

rht commented Jan 24, 2024

Wait, never mind. self.schedule.steps() never gets called. This is probably not the right fix. @tpike3 may know the problem better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants