Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve visual styling of grid drawing #2438

Open
quaquel opened this issue Oct 30, 2024 · 7 comments · May be fixed by #2609
Open

Improve visual styling of grid drawing #2438

quaquel opened this issue Oct 30, 2024 · 7 comments · May be fixed by #2609

Comments

@quaquel
Copy link
Member

quaquel commented Oct 30, 2024

Grids are optionally drawn for all discrete spaces. However, the look is not always esthetically pleasing. It might be worth to spend some time to tune how grids are drawn for all spaces.

@AdeebaNizam404
Copy link

Can u please assign this issue to me ..... I want to work on it ....

@EwoutH
Copy link
Member

EwoutH commented Nov 11, 2024

Thanks for showing interest, @quaquel good by you?

@quaquel
Copy link
Member Author

quaquel commented Nov 11, 2024

Yes go ahead and put forward your ideas. Note that it should be done in a way that does not break the existing API, although having more user control (so expanding the API) would be fine. Moreover, even if you were to start on the matplotlib side, it is important to have a sense of how it might work for altair as well.

@Sahil-Chhoker
Copy link
Contributor

@quaquel I would like to work on this issue, but I don't understand what's wrong with the current grids. Do you mind explaining what's not so esthetically pleasing about them?

@quaquel
Copy link
Member Author

quaquel commented Jan 8, 2025

When visualizing discrete spaces, hashed lines are used by default to draw the grid. See, any of the advanced examples for an illustration. Moreover, in particular in case of hexgrids, the way this grid is created is problematic because it results in overplotting. Again, create a hexgrid and visualize it using matplotlib to get a sense of what I mean.

also see here

@Sahil-Chhoker
Copy link
Contributor

Should the function allow changing the style of the old dotted line using a single parameter, or should it support customizing various parameters such as line width, color, or linestyle? Alternatively, should it include automatic functionality, like adjusting the line width based on the distance between two lines (though it's unclear if this is feasible)?

@quaquel
Copy link
Member Author

quaquel commented Jan 10, 2025

Anything goes, and ideas are welcome. However, please see my earlier remarks above.

My hunch is to start simple: solve the hex tiling overplotting issue first.

My longer-term vision, in light also of #2557 and #2437, is to separate explicitly the drawing of the space itself from the drawing of agents within the space. Drawing the space itself involves support for property layers and support for any gridding. Agent drawing is well covered already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants