Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reimplementation of draw_voroinoi #2608

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Conversation

quaquel
Copy link
Member

@quaquel quaquel commented Jan 10, 2025

This reimplements draw_voroinoi and makes it behave identically to draw_hexgrids. This, therefore, removes cell_coloring_property from the Voronoi grid. It also adds the draw_grid boolean to draw_voroinoi which is also available for all other discrete spaces.

Any future work on further developing the API for controlling how to draw a space itself such as #2438 and #2557, now at least can start from an underlying consistent code base.

Before
Unknown

After
Unknown2

Closes #2437 and #2549

@quaquel quaquel merged commit baf5c87 into projectmesa:main Jan 10, 2025
11 checks passed
@EwoutH EwoutH added enhancement Release notes label visualisation labels Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Release notes label visualisation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor refactoring of VoroinoiGrid
2 participants