Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix in global_benchmark.py #2509

Merged
merged 2 commits into from
Nov 16, 2024
Merged

Conversation

quaquel
Copy link
Member

@quaquel quaquel commented Nov 16, 2024

This PR moves the sys.insert statement to be before any mesa imports. The old version resulted in potentially importing the examples from the installed version of mesa.

@quaquel quaquel added the bug Release notes label label Nov 16, 2024
@quaquel quaquel requested a review from EwoutH November 16, 2024 13:04
@quaquel quaquel merged commit 134995f into projectmesa:main Nov 16, 2024
11 checks passed
Copy link

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
BoltzmannWealth small 🔵 +1.1% [+0.6%, +1.5%] 🔵 +1.2% [+1.0%, +1.4%]
BoltzmannWealth large 🔵 -0.0% [-0.6%, +0.5%] 🔵 -0.3% [-0.6%, +0.0%]
Schelling small 🔵 +1.2% [+0.9%, +1.5%] 🔵 +0.6% [+0.4%, +0.8%]
Schelling large 🔵 +0.1% [-0.7%, +0.7%] 🔵 +0.7% [-0.4%, +2.2%]
WolfSheep small 🔵 +0.6% [+0.3%, +0.9%] 🔵 +0.5% [+0.4%, +0.7%]
WolfSheep large 🔵 -0.1% [-0.6%, +0.5%] 🔵 +1.3% [-0.2%, +3.3%]
BoidFlockers small 🔵 -1.5% [-1.9%, -1.1%] 🔵 +0.5% [-0.0%, +1.0%]
BoidFlockers large 🔵 -0.9% [-1.7%, +0.2%] 🔵 +0.3% [-0.6%, +1.2%]

@EwoutH EwoutH added the ignore-for-release PRs that aren't included in the release notes label Nov 16, 2024
@quaquel quaquel deleted the benchmark_bug branch January 6, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Release notes label ignore-for-release PRs that aren't included in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants