-
Notifications
You must be signed in to change notification settings - Fork 1k
Added aliases for terms in viz modules #2634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Performance benchmarks:
|
I am not sure about the need for this PR, although I realize this was suggested by @EwoutH. Why might this not be needed
|
It's always good advice to check with (multiple) maintainers if something is necessary / useful / worthwhile before working on something. This can be a simple as a quick message in the Matrix chat or a follow-up comment on a PR or issue. I don't have a strong opinion on this I will leave this to be @quaquel's call. |
@quaquel do or don't? |
@quaquel @Corvince @Sahil-Chhoker I'm totally indifferent on this PR, but it might be great to give @sanika-n clarity if we want to move forward with it. Especially now that we stabilized the Cell Space. Do any of you have an opinion on it? |
I don't see much value in it at the moment. |
I am also with @quaquel here, and this comment gives proper explanation for that. |
Thanks for the PR anyways Sakina, and sorry for adding the confusion with the issue! |
No problem at all ! I should have asked before starting to work on it and anyways it was only a couple of lines of code:) |
In one of the comments present in the code review for this PR #2430 , there was a request to make some of the aliases related to the visualization module centralized, this PR aims to do that. The link can be found here

@EwoutH, I am not exactly sure if you meant to make it centralized throughout mesa or just in the visualization module. Since all the aliases were related to the visualization module, I have added it there.