-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented post_process in Altair based components #2641
base: main
Are you sure you want to change the base?
Conversation
Performance benchmarks:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sanika-n!
Could you update the docstrings to ensure the API accurately reflects the change (~ Line 33) https://mesa.readthedocs.io/stable/apis/visualization.html#module-mesa.visualization.components.altair_components
And although this passes the tests check, it would be good to add a test to post process in the solara_viz test
Line 100 in 13518b2
mock_space_altair = mocker.spy( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Feature
I implemented post_process for Altair based components. And I just tested it out on the Boltzmann Wealth Model, with the following code:
Before
After