Skip to content

Minor (bug) fixes to discrete_space #2687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 13, 2025
Merged

Conversation

quaquel
Copy link
Member

@quaquel quaquel commented Feb 12, 2025

  1. This adds mesa.discrete_space to __init__. You can now do from mesa import discrete_space. This also fixes the failing benchmarks.
  2. This solves cell.agents is prone to create bugs #2682. Cell.agents now returns a copy of the list of agents in the cell, rather than the actual list. This reduces the potential for nasty side effects. Since Cell already has add_agent and remove_agent, this was a simple fix.

@quaquel quaquel requested review from EwoutH and Corvince February 13, 2025 06:28
@quaquel quaquel added trigger-benchmarks Special label that triggers the benchmarking CI bug Release notes label labels Feb 13, 2025
@quaquel quaquel linked an issue Feb 13, 2025 that may be closed by this pull request
@quaquel quaquel merged commit 22817e7 into projectmesa:main Feb 13, 2025
11 of 13 checks passed
@quaquel quaquel deleted the discrete_space branch February 15, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Release notes label trigger-benchmarks Special label that triggers the benchmarking CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cell.agents is prone to create bugs
2 participants