Eval 2 - reddit #225
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
|
|
||
| <head> | ||
| <meta charset="UTF-8"> | ||
| <title>Page</title> | ||
| <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/bootstrap@3.3.7/dist/css/bootstrap.min.css" | ||
| integrity="sha384-BVYiiSIFeK1dGmJRAkycuHAHRg32OmUcww7on3RYdg4Va+PmSTsz/K68vbdEjh4u" crossorigin="anonymous"> | ||
| <link href="style.css" rel="stylesheet"> | ||
| </head> | ||
|
|
||
| <body> | ||
| <div class="container"> | ||
| <header> | ||
| <h1>Reddit</h1> | ||
| </header> | ||
| </div> | ||
| <main class="container"> | ||
| <hr> | ||
| <div class="comment-btns"> | ||
| <span class="rm-comments-btn">remove</span> | ||
| <span class="show-comments-btn">comments:</span> | ||
| </div> | ||
| <span class="new-comments">I'm a comment - Posted By: Jeff | ||
| <br></span> | ||
| <div class="comment-btns"> | ||
| <hr> | ||
| <span class="rm-comments-btn">remove</span> | ||
| <span class="show-comments-btn">comments:</span> | ||
| </div> | ||
| <span class="new-comments">Here's a comment - Posted By: Jeff <br> | ||
| </span> | ||
| <hr> | ||
| <input class="post" type="text" placeholder="Post Text" /> | ||
| <input class="name" type="text" placeholder="Your Name" /> | ||
| <ul class="nav nav-pills"> | ||
| <li role="presentation" class="active"><a href="#">Submit</a></li> | ||
|
Comment on lines
+36
to
+37
There was a problem hiding this comment. never use ul or lists for buttons, use the button tag and you have 'btn btn-primary' bootstrap classes |
||
| </ul> | ||
| </main> | ||
| </body> | ||
| <script src="main.js"></script> | ||
|
|
||
| </html> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| const submitButton = document.getElementsByClassName('active')[0]; | ||
|
There was a problem hiding this comment. better to have consistency, either use getElementsByClassName or querySelector |
||
|
|
||
| submitButton.addEventListener('click', function () { | ||
|
|
||
| const inputPost = document.getElementsByClassName('post')[0].value; | ||
| const inputName = document.getElementsByClassName('name')[0].value; | ||
|
|
||
| const newSpan = document.createElement('span'); | ||
| newSpan.innerHTML = `${inputPost}, posted by ${inputName}`; | ||
|
There was a problem hiding this comment. this is less recommented, use textContent or appendChild as they are safer and more performant.
Comment on lines
+4
to
+9
There was a problem hiding this comment. your code alignment is off, check your lint settings. This affects readability. |
||
| const lineBreak = document.createElement('br'); | ||
|
|
||
| const commentContainer = document.querySelector('.new-comments'); | ||
| commentContainer.appendChild(newSpan); | ||
| commentContainer.appendChild(lineBreak); | ||
| }); | ||
|
|
||
| const rmButton = document.getElementsByClassName('rm-comments-btn')[0]; | ||
| rmButton.addEventListener('click', function () { | ||
| const commentsContainer = document.querySelector('.new-comments'); | ||
| commentsContainer.innerHTML = ''; | ||
| }) | ||
|
|
||
| const toggleButtons = document.querySelectorAll('.show-comments-btn'); | ||
|
|
||
|
|
||
|
|
||
| toggleButtons.forEach(button => { | ||
|
There was a problem hiding this comment. this should have been a separate function with ternary operation https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Conditional_operator |
||
| button.addEventListener('click', function () { | ||
|
|
||
|
|
||
| const comments = this.parentElement.nextElementSibling; | ||
|
|
||
|
|
||
|
Comment on lines
+30
to
+31
|
||
| if (comments.style.display === 'none' || comments.style.display === '') { | ||
| comments.style.display = 'block'; | ||
| } else { | ||
| comments.style.display = 'none'; | ||
| } | ||
| }); | ||
| }); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| .container { | ||
| display: grid; | ||
| justify-content: center; | ||
| } | ||
|
|
||
| hr { | ||
| background-color: black; | ||
| color: black; | ||
| } | ||
|
|
||
| .rm-comments-btn { | ||
| background-color: blue; | ||
| border-radius: 5px; | ||
| padding: 2px; | ||
| font-size: 80%; | ||
| color: white; | ||
| } | ||
|
|
||
| .show-comments-btn { | ||
| margin-left: 5px; | ||
| background-color: blue; | ||
| border-radius: 5px; | ||
| padding: 2px; | ||
| font-size: 80%; | ||
| color: white; | ||
| } | ||
|
|
||
| input { | ||
| width: 400px; | ||
| margin: 5px; | ||
| } | ||
|
|
||
| hr { | ||
| width: 95%; | ||
| } | ||
|
|
||
| .active { | ||
| margin-left: 4px; | ||
| } | ||
|
|
||
| /* button { | ||
|
|
||
| background-color: royalblue; | ||
| color: white; | ||
| border-radius: 5px; | ||
| margin-left: 7px; | ||
| width: 24%; | ||
| font-size:70%; | ||
| } */ | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same, could have been buttons