-
Notifications
You must be signed in to change notification settings - Fork 223
Project Reddit (2) #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Jasonsdc13
wants to merge
2
commits into
projectshft:master
Choose a base branch
from
Jasonsdc13:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Project Reddit (2) #228
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| <head> | ||
| <title>ReReddit</title> | ||
| <link rel="stylesheet" href="style.css"> | ||
| <link href="http://maxcdn.bootstrapcdn.com/bootstrap/3.2.0/css/bootstrap.min.css" rel="stylesheet"> | ||
| </head> | ||
| <body> | ||
| <div class="row"> | ||
| <div class="col-md-6 col-md-offset-3"> | ||
|
|
||
| <div class="page-header"> | ||
| <h1>Rereddit</h1> | ||
| </div> | ||
| <form style="margin-top:30px;" onsubmit="event.preventDefault();"> | ||
| <div class="posts"> | ||
| </div> | ||
|
|
||
| <h3>Add a new post</h3> | ||
|
|
||
| <div class="form-group"> | ||
| <input id="message" type="text" | ||
| class="form-control" | ||
| placeholder="Post Text"></input> | ||
| </div> | ||
|
|
||
| <div class="form-group"> | ||
| <input id="name" type="text" | ||
| class="form-control" | ||
| placeholder="Your Name"></input> | ||
| </div> | ||
|
|
||
| <button id="submit" class="btn btn-primary">Submit Post</button> | ||
| </form> | ||
|
|
||
| </div> | ||
| </div> | ||
|
|
||
| <script src="main.js"></script> | ||
| </body> | ||
| </html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,112 @@ | ||
| document.getElementById('submit').addEventListener('click', function () { | ||
|
|
||
| let name = document.getElementById('name').value; | ||
| let text = document.getElementById('message').value; | ||
|
|
||
| if (!name || !text) { | ||
| alert('Please fill in both name and text.'); | ||
| return; | ||
| } | ||
|
|
||
| let postsDiv = document.querySelector('.posts'); | ||
| let newPostDiv = document.createElement('div'); | ||
| newPostDiv.classList.add('post') | ||
|
|
||
| let commentsButton = document.createElement('a'); | ||
| commentsButton.href = "#"; | ||
| commentsButton.classList.add('btn', 'comments-btn'); | ||
| commentsButton.textContent = 'Comments'; | ||
| newPostDiv.append(commentsButton); | ||
|
|
||
| let removeButton = document.createElement('a'); | ||
| removeButton.href = "#"; | ||
| removeButton.classList.add('btn', 'remove-btn'); | ||
| removeButton.textContent = 'Remove'; | ||
| removeButton.addEventListener('click', function () { | ||
| postsDiv.removeChild(newPostDiv) | ||
| }); | ||
| newPostDiv.append(removeButton); | ||
|
|
||
| let newPostTextP = document.createElement('p'); | ||
| let newPostTextNode = document.createTextNode(text); | ||
| newPostTextP.appendChild(newPostTextNode); | ||
|
|
||
| let newPostNameP = document.createElement('p'); | ||
| let newPostNameNode = document.createTextNode('Posted by: ' + name); | ||
| newPostNameP.appendChild(newPostNameNode); | ||
|
|
||
| newPostDiv.append(newPostTextP.textContent + " - " + newPostNameP.textContent); | ||
| postsDiv.append(newPostDiv); | ||
|
|
||
| let newPostHR = document.createElement('hr'); | ||
| newPostDiv.append(newPostHR); | ||
|
|
||
| document.getElementById('name').value = ''; | ||
| document.getElementById('message').value = ''; | ||
|
|
||
| let commentSectionVisible = false; | ||
| commentsButton.addEventListener('click', function () { | ||
| if (commentSectionVisible) { | ||
| newCommentContainer.style.display = 'none'; | ||
| commentsButton.textContent = 'Comments'; | ||
| } else { | ||
| newCommentContainer.style.display = 'block'; | ||
| commentsButton.textContent = 'Hide Comments'; | ||
| } | ||
| commentSectionVisible = !commentSectionVisible; | ||
| }); | ||
|
|
||
| //comment section for comments | ||
| let newCommentContainer = document.createElement('div'); | ||
| newCommentContainer.classList.add('new-comment'); | ||
|
|
||
| let commentNameInput = document.createElement('input'); | ||
| commentNameInput.classList.add('comment-name'); | ||
| commentNameInput.placeholder = 'Your name'; | ||
|
|
||
|
|
||
| let commentTextInput = document.createElement('input'); | ||
| commentTextInput.classList.add('comment-input'); | ||
| commentTextInput.placeholder = 'Comment Text'; | ||
|
|
||
| let newCommentButton = document.createElement('a'); | ||
| newCommentButton.href = "#"; | ||
| newCommentButton.classList.add('btn', 'new-comment-btn'); | ||
| newCommentButton.textContent = 'Submit Comment' | ||
|
|
||
| newCommentButton.addEventListener('click', function() { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. too many listeners, this causes performance issues |
||
| let commentName = commentNameInput.value; | ||
| let commentText = commentTextInput.value; | ||
|
|
||
| if (!commentName || !commentText) { | ||
| alert('Please fill in both name and text.'); | ||
| return; | ||
| } | ||
|
|
||
| let commentDiv = document.createElement('div'); | ||
| commentDiv.classList.add('comment'); | ||
|
|
||
| let commentNameP = document.createElement('p'); | ||
| commentNameP.textContent = 'Posted by: ' + commentName; | ||
|
|
||
| let commentTextP = document.createElement('p'); | ||
| commentTextP.textContent = commentText; | ||
|
|
||
| let newRemoveButton = document.createElement('a'); | ||
| newRemoveButton.href = "#"; | ||
| newRemoveButton.classList.add('btn', 'new-remove-btn'); | ||
| newRemoveButton.textContent = 'Remove'; | ||
| newRemoveButton.addEventListener('click', function () { | ||
| commentDiv.remove(); | ||
| }); | ||
|
|
||
| commentDiv.append(newRemoveButton, commentTextP.textContent + " - " + commentNameP.textContent); | ||
| newCommentContainer.appendChild(commentDiv); | ||
|
|
||
| commentNameInput.value = ''; | ||
| commentTextInput.value = ''; | ||
| }) | ||
|
|
||
| newCommentContainer.append(commentNameInput, commentTextInput, newCommentButton); | ||
| newPostDiv.appendChild(newCommentContainer); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| .posts .post { | ||
| margin-bottom: 20x; | ||
| padding: 15px; | ||
| border-radius: 8px; | ||
| background-color: #fff; | ||
| } | ||
|
|
||
| .comments-btn { | ||
| margin-top: 10px; | ||
| display: inline-block; | ||
| } | ||
|
|
||
| .remove-btn { | ||
| margin-top: 10px; | ||
| display: inline-block; | ||
| } | ||
|
|
||
| .new-remove-btn { | ||
| margin-top: 10px; | ||
| display: inline-block; | ||
| } | ||
|
|
||
| .new-comment-btn { | ||
| margin-top: 10px; | ||
| display: inline-block; | ||
| background-color: #008cba; | ||
| color: white; | ||
| } | ||
|
|
||
| .comment-name, | ||
| .comment-input { | ||
| width: 100%; | ||
| padding: 10px; | ||
| margin: 10px 0; | ||
| border: 1px solid #ccc; | ||
| font-size: 14px; | ||
| box-sizing: border-box; | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are appending a string and not a dom element,
newPostDiv.append(newPostTextP, newPostNameP);