Open
Conversation
added 4 commits
May 27, 2023 08:58
…five day forecast sparklines for temp, pressure, and humidity.
…ut value after submitting. and performed general clean-up of all code.
lmicek
reviewed
Jun 14, 2023
| city: action.payload.data.city.name, | ||
|
|
||
| // creates an array of all the 5 day forecast data for temp, pressure, and humidity. The array will be used for sparklines | ||
| temps: action.payload.data.list.map(obj => obj.main.temp), |
There was a problem hiding this comment.
Don't recommend using generic terms like obj to name things. Be as descriptive as possible with naming.
| import _ from 'lodash'; | ||
|
|
||
|
|
||
| const ForecastList = () => { |
There was a problem hiding this comment.
I see a lot of inconsistency in how you are writing functions (expression/declaration). It is good to stay consistent.
| @@ -0,0 +1,16 @@ | |||
| const header = (props) => { | |||
There was a problem hiding this comment.
I really like how you broke this out into components, nice work!
|
|
||
| // clears value from input once submitted | ||
| reset(); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.