Skip to content

redux-weather#79

Open
kelseyb55 wants to merge 6 commits intoprojectshft:masterfrom
kelseyb55:master
Open

redux-weather#79
kelseyb55 wants to merge 6 commits intoprojectshft:masterfrom
kelseyb55:master

Conversation

@kelseyb55
Copy link

No description provided.

@@ -0,0 +1,23 @@
import axios from "axios";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

axios is missing from your package.json

src/App.js Outdated
import { Container } from 'react-bootstrap';
import Row from 'react-bootstrap/Row';
import Col from 'react-bootstrap/Col';
import Header from '.components/header';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incorrect paths

@@ -0,0 +1,31 @@
import { fetchWeather } from "../actions/actions";
import { useState } from "react";
import { useDispatch } from "react";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useDispatch should be imported from react-redux

@@ -6,9 +6,14 @@
"@testing-library/jest-dom": "^5.11.10",
"@testing-library/react": "^11.2.6",
"@testing-library/user-event": "^12.8.3",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of packages missing


export function fetchWeather (city) {

const search = axios.get(`api.openweathermap.org/data/2.5/forecast?q=${city}&appid=40a22fcb01995614a7b68804376359eb`)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing https:// from the call

let cityName = '';
action.payload.data.list.map((section, index) => {
temperature.push(section.main.temp)
humidity.pudh(section.main.humidity)
Copy link

@lmicek lmicek Jun 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax error here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants