Open
Conversation
lmicek
reviewed
Nov 9, 2023
| @@ -0,0 +1 @@ | |||
| VITE_API_KEY=731a6fa24765316e8e44e6e18157a6bd | |||
There was a problem hiding this comment.
generally you don't check .env into your repo cause it exposes things that shouldn't be public like keys. you would want to put this in your .gitignore
| To run locally, fork and clone this repository. `cd` into the directory you created and execute the following commands: | ||
|
|
||
| ``` | ||
| npm install |
There was a problem hiding this comment.
nice job on the readme! it is great to put all instructions on how to run the app in here.
| }; | ||
|
|
||
| const handleSearchButton = () => { | ||
| if (search !== '') { |
There was a problem hiding this comment.
this could be simplified to if (search) - review the concept of truthy and falsy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I accidentally deleted the commit history when I first forked the project, so I had to re-fork and copy-paste all my code so that they shared the same histories and could be merged.