Scott Bouchard Redux-Weather eval#86
Open
holdwhatdoor wants to merge 4 commits intoprojectshft:masterfrom
Open
Scott Bouchard Redux-Weather eval#86holdwhatdoor wants to merge 4 commits intoprojectshft:masterfrom
holdwhatdoor wants to merge 4 commits intoprojectshft:masterfrom
Conversation
lmicek
reviewed
Dec 3, 2023
|
|
||
| // checks that returned api call data array is not empty then assigns variable values | ||
| if (forecasts.forecasts.forecasts.length !== 0) { | ||
| searchedCity = forecasts.forecasts.forecasts[0].city.name; |
There was a problem hiding this comment.
Would recommend not to hard code an index like this, use array method to find the value you need instead
|
|
||
| /** | ||
| * Function to render a Sparklines visual graph of input array plot points | ||
| * with median line for average of array |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.