Michael Wagner Weather Eval #13
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| 'use client'; | ||
| import { useState } from 'react'; | ||
| import { useDispatch } from 'react-redux'; | ||
| import { fetchWeather } from '../store/slices/cities'; | ||
|
|
||
| export default function CitySearch() { | ||
| //setting up useState and Dispatch | ||
| const dispatch = useDispatch(); | ||
| const [city, setCity] = useState(''); | ||
| //submit button function that requests API and formats API and sets useState back to '' | ||
| const handleFormSubmit = (event) => { | ||
| event.preventDefault(); | ||
| dispatch(fetchWeather(city)); | ||
| setCity(''); | ||
| }; | ||
| //UI for the Submit form area with submit button | ||
| return ( | ||
| <form onSubmit={handleFormSubmit}> | ||
| <div className='col-6 offset-3'> | ||
| <label>Enter City Name</label> | ||
| <input | ||
| className='form-control' | ||
| value={city} | ||
| onChange={(event) => setCity(event.target.value)} | ||
| ></input> | ||
| <br /> | ||
| <button className='btn btn-primary' type='submit'> | ||
| Submit | ||
| </button> | ||
| </div> | ||
| </form> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| 'use client'; | ||
| import React from 'react'; | ||
| import { useSelector } from 'react-redux'; | ||
| import { | ||
| Sparklines, | ||
| SparklinesReferenceLine, | ||
| SparklinesLine, | ||
| SparklinesCurve, | ||
| } from 'react-sparklines'; | ||
|
|
||
| export default function CityWeather() { | ||
| const cities = useSelector((state) => state.cities.cities); | ||
| //function to get averages of weather data | ||
| const getAverage = (array) => | ||
| Math.round( | ||
| array.reduce((sum, currentValue) => sum + currentValue, 0) / | ||
| array.length | ||
| ); | ||
| //displays cities weather with charts if they have been passed in. Has averages below each chart. If no info displays no weather data | ||
| const renderCities = () => { | ||
| if (cities.length > 0) { | ||
| return cities.map((city, index) => { | ||
| return ( | ||
| <tbody key={index}> | ||
| <tr> | ||
| <th scope='row'>{city.cityName}</th> | ||
| <td> | ||
| <Sparklines data={city.temp}> | ||
| <SparklinesLine color='blue' /> | ||
| <SparklinesReferenceLine type='avg' /> | ||
| </Sparklines> | ||
| </td> | ||
| <td> | ||
| <Sparklines data={city.pressure}> | ||
| <SparklinesLine color='red' /> | ||
| <SparklinesReferenceLine type='avg' /> | ||
| </Sparklines> | ||
| </td> | ||
| <td> | ||
| <Sparklines data={city.humidity}> | ||
| <SparklinesLine color='yellow' /> | ||
| <SparklinesReferenceLine type='avg' /> | ||
| </Sparklines> | ||
| </td> | ||
|
Comment on lines
+27
to
+44
There was a problem hiding this comment. DRY, don't repeat yourself, use JS helpers and components to make it more readable |
||
| </tr> | ||
| <tr> | ||
| <th></th> | ||
| <td>{getAverage(city.temp)}(F)</td> | ||
| <td>{getAverage(city.pressure)}(hPa)</td> | ||
| <td>{getAverage(city.humidity)}(%)</td> | ||
| </tr> | ||
| </tbody> | ||
| ); | ||
| }); | ||
| } else { | ||
| return <div>No Weather Data To Show</div>; | ||
| } | ||
| }; | ||
|
|
||
| //ui for the City Weather section of the app. Displayed in table format | ||
| return ( | ||
| <table className='table'> | ||
| <thead> | ||
| <tr className='text-bold'> | ||
| <th scope='col'>City</th> | ||
| <th scope='col'>Temperature(F)</th> | ||
| <th scope='col'>Pressure(hPa)</th> | ||
| <th scope='col'>Humidity(%)</th> | ||
| </tr> | ||
| </thead> | ||
| {renderCities()} | ||
| </table> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,107 +0,0 @@ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,17 @@ | ||
| 'use client'; | ||
| import './globals.css'; | ||
| import { Inter } from 'next/font/google'; | ||
| import { Provider } from 'react-redux'; | ||
| import 'bootstrap/dist/css/bootstrap.css'; | ||
| import store from './store/configureStore'; | ||
| const inter = Inter({ subsets: ['latin'] }); | ||
| //boilerplate | ||
| export default function RootLayout({ children }) { | ||
| return ( | ||
| <html lang='en'> | ||
| <body className={inter.className}> | ||
| <Provider store={store}>{children}</Provider> | ||
| </body> | ||
| </html> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,95 +1,21 @@ | ||
| import CitySearch from './components/citySearch'; | ||
| import CityWeather from './components/cityWeather'; | ||
|
|
||
| //ui for application | ||
| export default function Home() { | ||
| return ( | ||
| <body> | ||
| <div className='text-center'> | ||
| <h1>Weather App</h1> | ||
| </div> | ||
| <br /> | ||
| <br /> | ||
|
Comment on lines
+11
to
+12
There was a problem hiding this comment. Its not a good practice to use breaks for design purposes. Next time use css |
||
| <div className='text-center'> | ||
| <CitySearch /> | ||
| <br /> | ||
| <br /> | ||
| <CityWeather /> | ||
| </div> | ||
| </body> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| import { configureStore } from '@reduxjs/toolkit'; | ||
| import rootReducer from './rootReducer'; | ||
|
|
||
| const store = configureStore({ | ||
| reducer: rootReducer, | ||
|
|
||
| }); | ||
|
|
||
| export default store; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| import { combineReducers } from 'redux'; | ||
| import citiesReducer from './slices/cities'; | ||
|
|
||
| const rootReducer = combineReducers({ | ||
| cities: citiesReducer, | ||
| }); | ||
|
|
||
| export default rootReducer; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its a better UX to clear the input only after the call is successful. If the user enters a bad input, you want to see it and not clear it