Redux Eval #26
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| { | ||
| "workbench.colorCustomizations": { | ||
| "activityBar.activeBackground": "#2f7c47", | ||
| "activityBar.background": "#2f7c47", | ||
| "activityBar.foreground": "#e7e7e7", | ||
| "activityBar.inactiveForeground": "#e7e7e799", | ||
| "activityBarBadge.background": "#422c74", | ||
| "activityBarBadge.foreground": "#e7e7e7", | ||
| "commandCenter.border": "#e7e7e799", | ||
| "sash.hoverBorder": "#2f7c47", | ||
| "statusBar.background": "#215732", | ||
| "statusBar.foreground": "#e7e7e7", | ||
| "statusBarItem.hoverBackground": "#2f7c47", | ||
| "statusBarItem.remoteBackground": "#215732", | ||
| "statusBarItem.remoteForeground": "#e7e7e7", | ||
| "titleBar.activeBackground": "#215732", | ||
| "titleBar.activeForeground": "#e7e7e7", | ||
| "titleBar.inactiveBackground": "#21573299", | ||
| "titleBar.inactiveForeground": "#e7e7e799" | ||
| }, | ||
| "peacock.color": "#215732" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,172 @@ | ||
| "use client"; | ||
| import { useEffect, useState } from "react"; | ||
| import { useDispatch, useSelector } from "react-redux"; | ||
| import { | ||
| deleteCity, | ||
| fetchForecast, | ||
| resetList, | ||
| } from "@/store/slices/forecastSlice"; | ||
|
|
||
| import { | ||
| Sparklines, | ||
| SparklinesLine, | ||
| SparklinesReferenceLine, | ||
| } from "react-sparklines"; | ||
|
|
||
| export default function CityView() { | ||
| const { forecastData, loading, error, cities } = useSelector( | ||
| (state) => state.forecast | ||
| ); | ||
|
|
||
| const dispatch = useDispatch(); | ||
|
|
||
| const [query, setQuery] = useState(""); | ||
|
|
||
| useEffect(() => {}, []); | ||
|
|
||
| const handleSearch = () => { | ||
| if (!query || query.trim() === "") { | ||
| alert("Search cannot be empty"); | ||
| setQuery(""); | ||
| } else { | ||
| dispatch(fetchForecast(query)); | ||
| setQuery(""); | ||
| } | ||
| }; | ||
|
|
||
| const handleReset = () => { | ||
| if (confirm("Are you sure you want to reset? ")) { | ||
| dispatch(resetList()); | ||
| } | ||
| }; | ||
|
|
||
| const handleInput = (event) => { | ||
| setQuery(event.target.value); | ||
| }; | ||
|
|
||
| const handleDelete = (cityId) => { | ||
| if (confirm("are you sure you want to delete this city?")) { | ||
| dispatch(deleteCity(cityId)); | ||
| } | ||
| }; | ||
|
|
||
| function average(arr) { | ||
|
There was a problem hiding this comment. very generic function name and argument, be specific |
||
| return arr.reduce((sum, num) => sum + num) / arr.length; | ||
| } | ||
|
|
||
| return ( | ||
| <div className="container"> | ||
| <div className="input-group m-5"> | ||
| <input | ||
| type="text" | ||
| className="form-control" | ||
| placeholder="Search city" | ||
| value={query} | ||
| onChange={handleInput} | ||
| required | ||
| /> | ||
| <button | ||
| type="button" | ||
| className="btn btn-primary" | ||
| onClick={handleSearch} | ||
| > | ||
| Search | ||
| </button> | ||
| </div> | ||
| <div className="container"> | ||
| <div className=" text-center"> | ||
| <button | ||
| type="button" | ||
| className="btn btn-danger btn-sm" | ||
| onClick={handleReset} | ||
| > | ||
| {" "} | ||
| reset list | ||
| </button> | ||
|
|
||
| </div> | ||
| </div> | ||
|
|
||
| <h2 className="text-center m-4">City Forecast</h2> | ||
| {loading && <div>Loading...</div>} | ||
| {!loading && error && <div>Error: {error}</div>} | ||
| {!loading && forecastData && ( | ||
| <div> | ||
| <table className="table"> | ||
| <thead> | ||
| <tr> | ||
| <th scope="col"></th> | ||
| <th scope="col">City</th> | ||
| <th scope="col">Temperature (°F)</th> | ||
| <th scope="col">Humidity (%)</th> | ||
| <th scope="col">Pressure (hPa)</th> | ||
| <th scope="col">Actions</th> | ||
| </tr> | ||
| </thead> | ||
| <tbody> | ||
| {cities.map((city) => { | ||
| const tempArray = city.list.map((item) => item.main.temp); | ||
| const humidityArray = city.list.map( | ||
| (item) => item.main.humidity | ||
| ); | ||
| const pressureArray = city.list.map( | ||
| (item) => item.main.pressure | ||
| ); | ||
|
|
||
| const tempAvg = Math.round(average(tempArray)); | ||
| const humidAvg = Math.round(average(humidityArray)); | ||
| const pressAvg = Math.round(average(pressureArray)); | ||
|
|
||
| return ( | ||
| <tr key={city.id} className="align-bottom"> | ||
| <td scope="row" className="align-middle"></td> | ||
| <td className="align-middle"> | ||
| <h2>{city.name}</h2> | ||
| </td> | ||
| <td className="align-bottom"> | ||
| <Sparklines data={tempArray} height={75} width={125}> | ||
| <SparklinesLine color="red" /> | ||
| <SparklinesReferenceLine type="mean" /> | ||
| </Sparklines> | ||
| <div className="text-center"> | ||
| {" "} | ||
| <h5>{tempAvg} °F </h5> | ||
| </div> | ||
| </td> | ||
| <td className="align-bottom"> | ||
| <Sparklines data={humidityArray} height={75} width={125}> | ||
| <SparklinesLine color="green" /> | ||
| <SparklinesReferenceLine type="mean" /> | ||
| </Sparklines> | ||
| <div className="text-center"> | ||
| {" "} | ||
| <h5>{humidAvg} %</h5> | ||
| </div> | ||
| </td> | ||
| <td className="align-bottom"> | ||
| <Sparklines data={pressureArray} height={75} width={125}> | ||
| <SparklinesLine color="blue" /> | ||
| <SparklinesReferenceLine type="mean" /> | ||
| </Sparklines> | ||
| <div className="text-center"> | ||
| <h5>{pressAvg} hPa </h5> | ||
| </div> | ||
| </td> | ||
| <td className="text-center align-middle"> | ||
| <button | ||
| onClick={() => handleDelete(city.id)} | ||
| className="btn btn-danger btn-sm" | ||
| > | ||
| Delete | ||
| </button> | ||
| </td> | ||
| </tr> | ||
| ); | ||
| })} | ||
| </tbody> | ||
| </table> | ||
| </div> | ||
| )} | ||
| </div> | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,107 +0,0 @@ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,20 @@ | ||
| "use client"; | ||
| import "bootstrap/dist/css/bootstrap.css"; | ||
| import { Signika_Negative } from "next/font/google"; | ||
| import { Provider } from "react-redux"; | ||
| import store from "@/store/configureStore"; | ||
|
|
||
| const signikaNegative = Signika_Negative({ | ||
| subsets: ["latin"], | ||
| weight: ["400", "500", "700"], | ||
| }); | ||
|
|
||
| export default function RootLayout({ children }) { | ||
| return ( | ||
| <html lang="en"> | ||
| <body className={signikaNegative.className}> | ||
| <Provider store={store}>{children}</Provider> | ||
| </body> | ||
| </html> | ||
| ); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DRY
create a function resetSearchBox that calls setQuery. Will help with readability also.