Stephen Swaringin sunglasses-io#167
Open
sswaringin wants to merge 7 commits intoprojectshft:masterfrom
Open
Conversation
…est user data to prevent corruption of the real user data
app/server.js
Outdated
| const { brandId } = req.params; | ||
| // Are there any matching brand IDs? | ||
| const matchingProducts = products.filter(product => product.categoryId === brandId); | ||
| if (matchingProducts.length === 0) { |
There was a problem hiding this comment.
its not really an error that there are no products with this brand
app/server.js
Outdated
| // Did the request query parameters include a productId? | ||
| const productId = req.params.productId; | ||
| if (!productId) { | ||
| return res.status(400).send('Missing required query parameter'); |
There was a problem hiding this comment.
be more specific with the error, here you are missing productId
app/server.js
Outdated
| } | ||
|
|
||
| if (Number(quantity) === 0 || quantity > 1000) { | ||
| return res.status(403).send('Unable to update the quantity to that value'); |
There was a problem hiding this comment.
this is not the correct error code. The client sent wrong value, its 400!
Suggested change
| return res.status(403).send('Unable to update the quantity to that value'); | |
| return res.status(400).send('Unable to update the quantity to that value'); |
ronyrosenberg
left a comment
ronyrosenberg
left a comment
There was a problem hiding this comment.
Great job!
2 tests are still failing
| const { brandId } = req.params; | ||
| // Are there any matching brand IDs? | ||
| const matchingProducts = products.filter(product => product.categoryId === brandId); | ||
| // if (matchingProducts.length === 0) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.