Open
Conversation
Comment on lines
+40
to
+43
| if (filteredProducts.length === 0) { | ||
| response.status(404); | ||
| response.send({ message: "No products found" }); | ||
| } else { |
There was a problem hiding this comment.
not accurate, is not a client error that there are no filtered products, you can return an empty array and show an empty state in the client.
| app.get("/brands/:id/products", (request, response) => { | ||
| // Get all products that match the brand id | ||
| // The sample data provided has a categoryId property that aligns with the brand id numbers - I think it would be better named "brandId" but chose not to change the existing data | ||
| const filteredProducts = products.filter((product) => { |
There was a problem hiding this comment.
you should validate that the brand id is correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.