Skip to content

sunglasses-io/TomWinskell#181

Open
tomwinskell wants to merge 28 commits intoprojectshft:masterfrom
tomwinskell:master
Open

sunglasses-io/TomWinskell#181
tomwinskell wants to merge 28 commits intoprojectshft:masterfrom
tomwinskell:master

Conversation

@tomwinskell
Copy link

Description

  • Write swagger.yaml
  • Write tests using Chai / Mocha
  • Write routes to pass tests

How Has This Been Tested?

Chai / Mocha automated tests for login, brand and cart.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have checked my code and corrected any misspellings

…e objects. Add authentication to cart routes. Define error responses.
…ndId not validated. Add invalid input to schema. Refactor error object as {error: string}.
…es. Add isValidBrandId and fetchProductsByBrandId methods in brandService.js.
…n cart service. Confirm test no access to protected route without bearer token.
…r's cart. Confirmed passing tests for adding products to cart.
…d before to login user and save jwt for cart tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant