Open
Conversation
…nd localhost send a 200 status code with the correct data
…w. Next to implement the users and brands tests and routes
…eg cases are taken care of. Done.
| const products = require('../initial-data/products.json'); | ||
|
|
||
| app.get('/api/products', (req, res) => { | ||
| res.status(200).json(products); |
| }); | ||
|
|
||
| app.get('/api/products/:id', (req, res) => { | ||
| const product = products.find(p => p.id === req.params.id); |
There was a problem hiding this comment.
no need to be cheap, keep it readable
Suggested change
| const product = products.find(p => p.id === req.params.id); | |
| const product = products.find(product => product.id === req.params.id); |
| }); | ||
|
|
||
| app.get('/api/users', (req, res) => { | ||
| res.status(200).json(users); |
| }); | ||
|
|
||
| app.get('/api/users/:username', (req, res) => { | ||
| const user = users.find(u => u.login.username === req.params.username); |
|
|
||
| // add item to a users cart | ||
| app.post('/api/users/:username/cart', (req, res) => { | ||
| const user = users.find(u => u.login.username === req.params.username); |
There was a problem hiding this comment.
dry, anything you can do to reuse?
| } | ||
|
|
||
| // If match found, return a success message (no token for now) | ||
| res.status(200).json({ message: 'Login successful' }); |
There was a problem hiding this comment.
this is not really authenticating, you need to return a token that then is sent on every call and every relevant api needs to check it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.