Audrey Clark's Weather App Eval#209
Open
audreyclarkdev wants to merge 7 commits intoprojectshft:masterfrom
Open
Audrey Clark's Weather App Eval#209audreyclarkdev wants to merge 7 commits intoprojectshft:masterfrom
audreyclarkdev wants to merge 7 commits intoprojectshft:masterfrom
Conversation
| displayForecast(processForecastData(forecastData.list)); | ||
| } | ||
| catch(error) { | ||
| console.error('Error fetching weather data:', error); |
There was a problem hiding this comment.
I would also display the error to the user.
| } | ||
| } | ||
| catch(error) { | ||
| alert('Not a valid city. Please try again.'); |
There was a problem hiding this comment.
great, this is the only error you may have? I think there can be more
Comment on lines
+90
to
+92
| <p class="fs-3 fw-bold">${city}</p> | ||
| <p class="fs-3 fw-bold">${Math.round(temp)}°F</p> | ||
| <p class="fs-4 fst-italic text-capitalize">${description}</p> |
| const result = []; | ||
| for (const day in dailyData) { | ||
| const temps = dailyData[day].temps; | ||
| const avgTemp = temps.reduce((sum, t) => sum + t, 0) / temps.length; |
There was a problem hiding this comment.
extract to a new function for readability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finally got everything working well and styled the way I wanted with Bootstrap 5.