Open
Conversation
main.js
Outdated
| @@ -0,0 +1,117 @@ | |||
| document.getElementById("search").addEventListener("click", function () { | |||
| const userSearch = document.getElementById("search-query").value; | |||
| console.log(userSearch); | |||
main.js
Outdated
| const userSearch = document.getElementById("search-query").value; | ||
| console.log(userSearch); | ||
|
|
||
| if (userSearch === "") { |
There was a problem hiding this comment.
same as the other project, this is not a good validation. Empty spaces make the api call
| fetchWeatherData(userSearch); | ||
| } | ||
|
|
||
| document.getElementById("search-query").value = ""; |
There was a problem hiding this comment.
for readability, you can extract this to a separate function like:
Suggested change
| document.getElementById("search-query").value = ""; | |
| const resetSearchInput() => { | |
| document.getElementById("search-query").value = ""; | |
| } |
main.js
Outdated
| }; | ||
|
|
||
| function handleError(error) { | ||
| console.log(`ERROR: ${error}`); |
There was a problem hiding this comment.
this is a good start but ideally you want to display a message in the html alerting the user he entered a wrong city or that there was a server error.
main.js
Outdated
|
|
||
| // Weekdays listed twice to account for overlap | ||
| const date = new Date(); | ||
| const days = [ |
There was a problem hiding this comment.
This is fixed, dont need to be recreated each time you call displayForecast, you can define on top of the file
main.js
Outdated
| const dayThree = data.list[23]; | ||
| const dayFour = data.list[31]; | ||
| const dayFive = data.list[39]; | ||
| const forecastDisplay = [dayOne, dayTwo, dayThree, dayFour, dayFive]; |
There was a problem hiding this comment.
DRY, can you think of a more efficient (less lines of code) to do this using an array helped method?
hint, map :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.