Skip to content

Kfabb weather-project eval #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kfabb wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Kfabb weather-project eval #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4ed2d1
Fixed Bugs, needs stylinglinting
Dec 17, 2024
bc9e7be
fixed linting, alignment
Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 44 additions & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
<!DOCTYPE html>
<html lang="en">
<head>
<link rel="stylesheet" href="style.css">
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no">

<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.0.0-alpha.6/css/bootstrap.min.css" integrity="sha384-rwoIResjU2yc3z8GV/NPeZWAv56rSmLldC3R/AZzGRnGxQQKnKkoFVhFQhNUwEyJ" crossorigin="anonymous">
</head>
<body>
<div class="container-fluid">
<div class="row">
<div class="col-md-6 offset-md-3">
<div class="page-header text-center">
<img src="weather.svg" alt="weather forecast graphic" height="150px" class="weatherImg">
<h1>Weather Project</h1>
<hr/>
</div>
<div>
<form>
<div class="input-group">
<input type="text" class="form-control city-name" placeholder="City Name">
<div class="input-group-btn">
<button class="btn btn-primary class search" type="button">
Search
</button>
</div>
</div>
</form>
</div>
<br>
<div class="current">

</div>
</div>
<div class="container-fluid">
<div class="five-day">

</div>
</div>
</div>
<script src="main.js" type="text/javascript"></script>
</body>
</html>
214 changes: 214 additions & 0 deletions main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,214 @@
const submitBtn = document.querySelector(".search");
const current = document.querySelector(".current");
const fiveDay = document.querySelector(".five-day");
const searchInput = document.querySelector(".city-name");
const clear = '<img src="http://openweathermap.org/img/wn/01d@2x.png">';
const clouds = '<img src="http://openweathermap.org/img/wn/04d@2x.png">';
const drizzle = '<img src="http://openweathermap.org/img/wn/09d@2x.png">';
const thunderStorm = '<img src="">';
const rain = '<img src="http://openweathermap.org/img/wn/10d@2x.png">';
const snow = '<img src"http://openweathermap.org/img/wn/11d@2x.png">';
const mist = '<img src="http://openweathermap.org/img/wn/50d@2x.png">';
let currentResults = [];
let fiveDayResults = [];
let conditionImg;

submitBtn.addEventListener("click", () => {
document.querySelector(".current").replaceChildren();
document.querySelector(".five-day").replaceChildren();
currentResults = [];
fiveDayResults = [];
conditionImg = "";
let city = searchInput.value;
Copy link

@ronyrosenberg ronyrosenberg Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here is where you can trim it


if (!city) {
alert("Please enter valid city name.");
} else {
fetchWeather(city);
}

searchInput.value = "";
});

async function fetchWeather(city) {
try {
const currentWeather = await fetch(
`https://api.openweathermap.org/data/2.5/weather?q=${city}&appid=8ecfabbc5fb6be8c3ec37ba3114514e4&units=imperial`
);
const currentWeatherData = await currentWeather.json();
getCurrentWeather(currentWeatherData);

const fiveDayForecast = await fetch(
`https://api.openweathermap.org/data/2.5/forecast?q=${city}&appid=8ecfabbc5fb6be8c3ec37ba3114514e4&units=imperial`
);
const fDFData = await fiveDayForecast.json();
getFiveDayForcast(fDFData);
} catch (error) {
console.error("Error fetching data");
alert("Weather inquiry failed.");
}
}

function getCurrentWeather(currentWeatherData) {
currentResults.push({
city: currentWeatherData.name,
temp: Math.floor(currentWeatherData.main.temp),
conditions: currentWeatherData.weather[0].main,
});
renderCurrentWeather(currentResults);
}

function getFiveDayForcast(fDFData) {
const fiveDayHourly = fDFData.list;
for (let i = 0; i < fiveDayHourly.length; i = i + 8) {
fiveDayResults.push(fiveDayHourly[i]);
}
renderFiveDayForecast(fiveDayResults);
}

function renderCurrentWeather(currentResults) {
const temp = currentResults[0].city;
const city = currentResults[0].temp;
let conditions = currentResults[0].conditions;

for (let i = 0; i < currentResults.length; i++) {
if (conditions === "Clouds") {
Copy link

@ronyrosenberg ronyrosenberg Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be optimized with a dictionary/object

const weatherIcons = {
  Clouds: clouds,
  Rain: rain,
 ... etc
};
conditionImg = weatherIcons[conditions] || mist;

conditionImg = clouds;
} else if (conditions === "Rain") {
conditionImg = rain;
} else if (conditions === "Clear") {
conditionImg = clear;
} else if (conditions === "Drizzle") {
conditionImg = drizzle;
} else if (conditions === "Thunderstorm") {
conditions = thunderStorm;
} else if (conditions === "Snow") {
conditionImg = snow;
} else {
conditionImg = mist;
}
const template = `
<div class="row">
<div class="col-sm-6">
<div class="card border-0 text-center">
<div class="card-body">
<h3 class="card-title">${temp}&deg</h5>
<h4 class="card-text">${city}</h4>
<p>${conditions}</p>
</div>
</div>
</div>
<div class="col-sm-6">
<div class="card border-0">
<div class="card-body">
${conditionImg}
</div>
</div>
</div>
</div>`;

document
.querySelector(".current")
.insertAdjacentHTML("beforeend", template);
}
}

function renderFiveDayForecast(fiveDayResults) {
Copy link

@ronyrosenberg ronyrosenberg Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functions are massive. contain a lot of logic and need to be refactor with a more single responsibility principle

const dailyForecasts = [];
for (let i = 0; i < fiveDayResults.length; i++) {
const dailyConditions = [];
const temp = Math.floor(fiveDayResults[i].main.temp);
const conditions = fiveDayResults[i].weather[0].main;
const date = new Date(fiveDayResults[i].dt_txt).getDay();
const daysOfWeek = [
"Sunday",
"Monday",
"Tuesday",
"Wednesday",
"Thursday",
"Friday",
"Saturday",
];
const day = daysOfWeek[date];
dailyConditions.push(fiveDayResults[i].weather[0].main);

if (conditions === "Clouds") {
conditionImg = clouds;
} else if (conditions === "Rain") {
conditionImg = rain;
} else if (conditions === "Clear") {
conditionImg = clear;
} else if (conditions === "Drizzle") {
conditionImg = drizzle;
} else if (conditions === "Thunderstorm") {
conditions = thunderStorm;
} else if (conditions === "Snow") {
conditionImg = snow;
} else {
conditionImg = mist;
}

dailyForecasts.push({
temp: temp,
conditions: conditions,
day: day,
conditionsImg: conditionImg,
});
}

const template = `<hr><div class="container">
<div class="row row-cols-5 h-25">
<div class="col day">
<div class="card border-0 text-center">
<div class="card-body">
<p class="card-title">${dailyForecasts[0].day}</p>
<h5>${dailyForecasts[0].temp}&deg</h5>
${dailyForecasts[0].conditionsImg}
<p>${dailyForecasts[0].conditions}</p>
</div>
</div>
</div>
<div class="col day">
<div class="card border-0 text-center">
<div class="card-body">
<p class="card-title">${dailyForecasts[1].day}</p>
<h5>${dailyForecasts[1].temp}&deg</h5>
${dailyForecasts[1].conditionsImg}
<p>${dailyForecasts[1].conditions}</p>
</div>
</div>
</div>
<div class="col day">
<div class="card border-0 text-center">
<div class="card-body">
<p class="card-title">${dailyForecasts[2].day}</p>
<h5>${dailyForecasts[2].temp}&deg</h5>
${dailyForecasts[2].conditionsImg}
<p>${dailyForecasts[2].conditions}</p>
</div>
</div>
</div>
<div class="col day">
<div class="card border-0 text-center">
<div class="card-body">
<p class="card-title">${dailyForecasts[3].day}</p>
<h5>${dailyForecasts[3].temp}&deg</h5>
${dailyForecasts[3].conditionsImg}
<p>${dailyForecasts[3].conditions}</p>
</div>
</div>
</div>
<div class="col day">
<div class="card border-0 text-center">
<div class="card-body">
<p class="card-title">${dailyForecasts[4].day}</p>
<h5>${dailyForecasts[3].temp}&deg</h5>
${dailyForecasts[3].conditionsImg}
<p>${dailyForecasts[3].conditions}</p>
</div>
</div>
</div>
</div>`;

document.querySelector(".five-day").insertAdjacentHTML("beforeend", template);
}
12 changes: 12 additions & 0 deletions style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
.day {
border: 1px solid black;
}

.five-day {
width: 100%;
flex-wrap: nowrap;
}

.weatherImg {
padding-top: 15px;
}
1 change: 1 addition & 0 deletions weather.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.