Evaluation | Tom Winskell | Complete#223
Open
tomwinskell wants to merge 23 commits intoprojectshft:masterfrom
Open
Evaluation | Tom Winskell | Complete#223tomwinskell wants to merge 23 commits intoprojectshft:masterfrom
tomwinskell wants to merge 23 commits intoprojectshft:masterfrom
Conversation
…forecasted and current weather using a template string. Displays with weather icons. TODO: tidy up the renderWx file, potentially refactoring into additional files, smaller files and functions.
…t looks for loop placeholder, loops over the html filling values from array, returns new html string.
… integrate into app.
…st items to 12pm for the location chosen are returned.
…trings. Json also loaded by webpack rather than by fetch API.
| const input = document.getElementById('search'); | ||
| const dropdown = document.getElementById('dropdown'); | ||
|
|
||
| function renderDropdown(filtered) { |
| .filter((city) => { | ||
| return city.name.toLowerCase().includes(query); | ||
| }) | ||
| .slice(0, 10); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please read read me. Project uses modules and is bundled using WebPack. A live demo is available. The demo is rendered from the production build in the /dist folder on the gh-pages branch of my repository. The repository I am submitting a pull request for here is the source code for the bundled code.