Skip to content

Commit

Permalink
i dont think theres a point in returning the namespace and clusternam…
Browse files Browse the repository at this point in the history
…e in collectloglevelconfig
  • Loading branch information
AdamSadek committed May 15, 2024
1 parent b83719b commit 9892c79
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion internal/commands/loglevel/set.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import (
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
)

Check failure on line 30 in internal/commands/loglevel/set.go

View workflow job for this annotation

GitHub Actions / build-ut

assignment mismatch: 2 variables but collectLogLevelConfiguration returns 4 values

Check failure on line 30 in internal/commands/loglevel/set.go

View workflow job for this annotation

GitHub Actions / build-static-test

assignment mismatch: 2 variables but collectLogLevelConfiguration returns 4 values
func updateDebuggingConfiguration(ctx context.Context, logSeverity libsveltosv1alpha1.LogLevel, component, namespace, clusterName string) error {
func updateDebuggingConfiguration(ctx context.Context, logSeverity libsveltosv1alpha1.LogLevel, component, namespace string, clusterName string) error {
cc, err := collectLogLevelConfiguration(ctx, namespace, clusterName)
if err != nil {
return err
Expand Down
2 changes: 1 addition & 1 deletion internal/commands/loglevel/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ func collectLogLevelConfiguration(ctx context.Context, namespace string, cluster
}

sort.Sort(byComponent(configurationSettings))
return configurationSettings, namespace, clusterName
return configurationSettings, nil
}

func updateLogLevelConfiguration(
Expand Down

0 comments on commit 9892c79

Please sign in to comment.