Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bash completion file #26

Closed
wants to merge 4 commits into from
Closed

add bash completion file #26

wants to merge 4 commits into from

Conversation

arthurzam
Copy link
Contributor

No description provided.

@arthurzam arthurzam requested a review from mgorny June 6, 2024 19:19
@antecrescent
Copy link

The typing CI issue (python/typeshed#11072) was fixed incorrectly upstream. I opened a new issue at python/typeshed#12127.

To temporarily silence this issue until it is fixed upstream, you could cast preset:

diff --git a/pycargoebuild/__main__.py b/pycargoebuild/__main__.py
index 91a38c5..b60c702 100644
--- a/pycargoebuild/__main__.py
+++ b/pycargoebuild/__main__.py
@@ -333,7 +333,9 @@ def main(prog_name: str, *argv: str) -> int:
                                   mode="w:xz",
                                   format=tarfile.GNU_FORMAT,
                                   encoding="UTF-8",
-                                  preset=9 | lzma.PRESET_EXTREME,
+                                  preset=typing.cast(
+                                      typing.Optional[typing.Listing[0,1,2,3,4,5,6,7,8,9]],
+                                      9 | lzma.PRESET_EXTREME),
                                   ) as tar_out:  # type: ignore
                     os.fchmod(cratef.fileno(), 0o666 & ~umask)
                     logging.info("Repacking crates ...")

Copy link

@antecrescent antecrescent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a look at the code and tested it locally for a bit, LGTM. I have one question, though. Why did you add a new wheel and sdist for the previous release to the dist directory? I didn't find anything related to it in the code and I don't think that re-releasing 0.13.2 is what you are going for. What am I missing? :)

@arthurzam
Copy link
Contributor Author

Had a look at the code and tested it locally for a bit, LGTM. I have on question, though. Why did you add a new wheel and sdist for the previous release to the dist directory? I didn't find anything related to it in the code and I don't think that re-releasing 0.13.2 is what you are going for. What am I missing? :)

I didn't notice that - a mistake, lol. Should be in gitignore, lol.

Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
.gitignore Outdated Show resolved Hide resolved
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mgorny mgorny closed this in 466f464 Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants