-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cargo: add support for GitLab #29
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Daichi Yamamoto <dev@dyama.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry for replying this late.
Signed-off-by: Daichi Yamamoto <dev@dyama.net>
Thank you for reviewing my poor code. The py3.9 test fails because I used a match statement, but py39 has been dropped in the latest pycargoebuild ebuild. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think py3.10+ is fine but please update GHA and tox.ini
.
…and |
Signed-off-by: Daichi Yamamoto <dev@dyama.net>
Signed-off-by: Daichi Yamamoto <dev@dyama.net>
fixed. |
Thanks. But please extend |
Signed-off-by: Daichi Yamamoto <dev@dyama.net>
I added a test for this PR. It was difficult to find a good example of using gitlab.com, but there are many projects using self-hosted GitLab, such as However, complete support for self-hosted GitLab that can be built directly by running pycargoebuild cannot be achieved without updating cargo.eclass, but I would like to work on that separately. |
Actually, adding a test to |
Signed-off-by: Daichi Yamamoto <dev@dyama.net>
Added. Please forgive my stupidity. |
Thank you. I think I'll test it a little more, and merge. |
Added GitLab support to cargo.py.
Additional tests have not yet been written, but the tests that already exist have passed.
As for demand, the following project uses (self-hosted) GitLab.
https://github.com/pop-os/xdg-desktop-portal-cosmic/blob/41c1e7c/Cargo.lock#L4633