Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenCost 1.109.0, which moved the default container registry to GHCR.io #4291

Closed
wants to merge 3 commits into from

Conversation

mattray
Copy link
Contributor

@mattray mattray commented Feb 26, 2024

What this PR does / why we need it

appVersion bump to 1.109.0, version bump to 0.2.0
Registry moved from quay.io -> ghcr.io
Renamed container to "opencost" from legacy "kubecost-cost-model" Removed "prod-" tag prefix, no longer used in ghcr.io
Synced the internal Prometheus defaults to match the documentation defaults

Which issue this PR fixes

n/a

Special notes for your reviewer

Tested locally with Kind and k3s

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

Copy link
Contributor

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for all its worth

Copy link

stale bot commented Apr 22, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@mattray
Copy link
Contributor Author

mattray commented Apr 24, 2024

The PR's still valid, I double-checked to make sure nothing's changed in the meantime. Hopefully we'll have OpenCost 1.110.0 out soon and we'll have another version bump.

appVersion bump to 1.109.0, version bump to 0.1.2
Registry moved from quay.io -> ghcr.io
Renamed container to "opencost" from legacy "kubecost-cost-model"
Removed "prod-" tag prefix, no longer used in ghcr.io
Synced the internal Prometheus defaults to match the documentation defaults

Signed-off-by: Matt Ray <github@mattray.dev>
Signed-off-by: Matt Ray <github@mattray.dev>
Signed-off-by: Matt Ray <github@mattray.dev>
@mattray
Copy link
Contributor Author

mattray commented Jun 28, 2024

Replaced by #4639

@mattray mattray deleted the opencost-1.109.0 branch June 28, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants