Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] install Gateway API CRDs for chart tests #4645

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

jkroepke
Copy link
Member

@jkroepke jkroepke commented Jun 28, 2024

What this PR does / why we need it

Ref #4622

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer

tested in https://github.com/prometheus-community/helm-charts/actions/runs/9718384972/job/26826154436?pr=4646

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
@jkroepke jkroepke requested review from GMartinez-Sisti and a team as code owners June 28, 2024 20:54
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Copy link
Member

@GMartinez-Sisti GMartinez-Sisti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is a phase 1 for something that will come later. Approved, feel few to merge when desired.

@jkroepke
Copy link
Member Author

jkroepke commented Jun 28, 2024

I assume this is a phase 1 for something that will come later. Approved, feel few to merge when desired.

Thanks! Yes #4646

@jkroepke jkroepke merged commit b51f6b0 into prometheus-community:main Jun 28, 2024
4 checks passed
@jkroepke jkroepke deleted the ci-gw-api branch June 28, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants