[prometheus-stackdriver-exporter] fix deployment annotations

[wsmolkowski]

What this PR does / why we need it

fix #4768

Which issue this PR fixes

• fixes [prometheus-stackdriver-exporter] Deployment metadata missing annotations #4768

Special notes for your reviewer

Checklist

• DCO signed
• Chart Version bumped
• Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

[wsmolkowski]

@rpahli when could you merge it?

[rpahli]

@wsmolkowski there are still build error. Can you pls fix the build, then we can merge your PR.

[rpahli]

@wsmolkowski any update on this? can you pls fix the lint error?

[sboschman]

Seems chart version 4.6.1 is broken, b/c:

    {{- with .Values.annotations }}
    annotations:
      {{- toYaml .Values.annotations | indent 6 }}
    {{- end }}

Error: template: prometheus-stackdriver-exporter/charts/prometheus-stackdriver-exporter/templates/deployment.yaml:9:24: executing "prometheus-stackdriver-exporter/charts/prometheus-stackdriver-exporter/templates/deployment.yaml" at <.Values.annotations>: nil pointer evaluating interface {}.annotations

with changes the context if I am not mistaken, so the toYaml will fail. As .Values should come from the root context, e.g. $.Values.annotations inside the with or simply {{- toYaml . | indent 6 }} should work.

[bc-bishwash]

This is causing errors, with default values file:

Error: Error: template: prometheus-stackdriver-exporter/templates/deployment.yaml:9:24: executing "prometheus-stackdriver-exporter/templates/deployment.yaml" at <.Values.annotations>: nil pointer evaluating interface {}.annotations

[devops-pump-games]

I'm not sure, but looks like you should use "{{- if .Values.annotations }}" to exclude error

  Error: template: prometheus-stackdriver-exporter/templates/deployment.yaml:9:24: executing "prometheus-stackdriver-exporter/templates/deployment.yaml" at <.Values.annotations>: nil pointer evaluating interface {}.annotations