tcp: fix panic on collector (#1699)

prometheus-community · Oct 17, 2024 · ce2df38 · ce2df38
1 parent 92b7e44
commit ce2df38
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/internal/collector/tcp/tcp_test.go b/internal/collector/tcp/tcp_test.go
@@ -10,3 +10,7 @@ import (
 func BenchmarkCollector(b *testing.B) {
 	testutils.FuncBenchmarkCollector(b, tcp.Name, tcp.NewWithFlags)
 }
+
+func TestCollector(t *testing.T) {
+	testutils.TestCollector(t, tcp.New, nil)
+}
diff --git a/internal/perfdata/v1/collector.go b/internal/perfdata/v1/collector.go
@@ -44,7 +44,7 @@ func (c *Collector) Collect() (map[string]map[string]perftypes.CounterValues, er
 		return nil, fmt.Errorf("QueryPerformanceData: %w", err)
 	}
 
-	if len(perfObjects) == 0 {
+	if len(perfObjects) == 0 || perfObjects[0] == nil || len(perfObjects[0].Instances) == 0 {
 		return map[string]map[string]perftypes.CounterValues{}, nil
 	}
 

diff --git a/internal/perfdata/v1/perflib.go b/internal/perfdata/v1/perflib.go
@@ -418,6 +418,10 @@ func QueryPerformanceData(query string, counterName string) ([]*PerfObject, erro
 			}
 		}
 
+		if counterName != "" {
+			return objects[i : i+1], nil
+		}
+
 		// Next perfObjectType
 		objOffset += int64(obj.TotalByteLength)
 		numFilteredObjects++