Fix links to java client documentation#2521
Merged
machine424 merged 1 commit intoprometheus:mainfrom Feb 20, 2025
Merged
Conversation
Signed-off-by: Chris McDonnell <camcdonn@gmail.com>
Contributor
Author
|
@RichiH This seems to fall under "everything else", so you seem appropriate to reach out to according to |
ChrisMcD1
changed the title
machine424
approved these changes
Feb 20, 2025
Member
machine424
left a comment
machine424
left a comment
There was a problem hiding this comment.
Thanks for this.
Regarding the other links, it seems that some sections could use a bit of polishing to better reflect the new version https://github.com/prometheus/client_java/tree/main/simpleclient-archive
You can try to reach out to them via https://cloud-native.slack.com/archives/C0514QW9V16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed some of these links were not working since the java client has moved their documentation from GitHub to their new docs site.
There are still 2 broken links that I did not fix in this PR because I could not find the corresponding new file.
https://github.com/prometheus/docs/blob/main/content/docs/instrumenting/writing_exporters.md?plain=1#L350
and
https://github.com/prometheus/docs/blob/main/content/docs/instrumenting/writing_exporters.md?plain=1#L387
But I figured it wouldn't hurt to make a PR for the ones that were trivial to fix!
I believe the
CONTRIBUTING.mdis asking me to ping the maintainers of the java client since the docs relate to their project, so @fstab @dhoard @tomwilkie