-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hw_counters metrics for infiniband device. #2827
base: master
Are you sure you want to change the base?
Add hw_counters metrics for infiniband device. #2827
Conversation
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
Beside these, maybe consider combining metrics that can be summed up (like multiple types of errors etc) into one with different labels. See https://prometheus.io/docs/practices/naming/ |
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
Hi, how is progress on this? We would love to have these counters :) |
thanks @discordianfish. Please re-check |
This would be really useful for us, any update? |
@SuperQ Please recheck it, thanks. |
Interested in this PR too. |
Ping again |
The general idea also applies to the other metrics. We need to carefully think about the names since changing them in the future is a breaking change that will need to be enabled by adding a flag etc etc. So sorry if that feels pedentic but we need to make sure we get these names right. Also, see my other comment here: #2827 (comment) PS: Sorry for not being responsive. I don't get paid to work on this so my availability is limited :-/ |
Thank you for your review. I will fix these issues as soon as possible. 🙏 |
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
@discordianfish Please re-check, thanks |
Better, thanks! Still, can you consider combining some of these metrics using the same name and different labels? |
Thanks for your review. Do you have any suggestions to combine some of these indicators using the same name and different labels? @discordianfish |
@dongjiang1989 That depends on the metrics, I don't really have the resources to go through all these and suggest something. See the linked best practices, particular this quote:
One candidate might be the error metrics where you could have one and distinguish between them via some sort of error type label etc |
The hw_counters is still important metrics, Hope to continue updating! |
So, wich release is targated to include the new hw counter? |
@SuperQ Ideally we have ssomeone with understanding of the best practices and experience with infiniband go over the naming but I'd be also ok to just merge this as it is for now.. |
Add hw_counters metrics for infiniband device.
ref: prometheus/procfs#549