Add reporting of purgeable space on MacOS #2907
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs formatting (see test fail) and DCO sign-off |
Purgeable space is space that macOS can free up when needed by removing files from your computer (you can't manually remove the files that are designated purgeable, but macOS removes them as space is required). So statfs can report low available space when in fact you can use more than that. Signed-off-by: Denis <per43014@adobe.com>
Signed-off-by: Denis <per43014@adobe.com>
SuperQ
requested changes
Feb 14, 2024
Also update metric name
|
Why close? This is almost ready. |
|
I cannot make my own diff work anymore 🤣 |
Signed-off-by: Denis Fondras <1040974+ledeuns@users.noreply.github.com>
Signed-off-by: Denis Fondras <1040974+ledeuns@users.noreply.github.com>
|
Tested on MacOS 14 (x86+M2) and Ubuntu 22.04 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purgeable space is space that macOS can free up when needed by removing files from your computer (you can't manually remove the files that are designated purgeable, but macOS removes them as space is required). So statfs can report low available space when in fact you can use more than that.