-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for GPU Clock Frequencies (sclk and mclk) in hwmon Collector #3093
base: master
Are you sure you want to change the base?
Conversation
here's the relevant kernel documentation reference: https://docs.kernel.org/gpu/amdgpu/thermal.html |
Hi, I know there is no unit test for hwmon_linux now. Is that possible we provide unit test for it? |
You can add a test file to the fixtures. This way it will be tested by the |
We're happy to provide tests for this if you'd like, but we'll leave it up to you (upstream) to decide whether you want to include them or keep it as is. |
Signed-off-by: Xuhui Zhu <simon.zhu@canonical.com>
Signed-off-by: Xuhui Zhu <simon.zhu@canonical.com>
Signed-off-by: Xuhui Zhu <simon.zhu@canonical.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Thanks for reviewing! Could someone with write access run the workflows, please? |
+1 |
@SuperQ PTAL |
Hi, just merged main branch. Could someone with write access run the workflows again please. Thank you. |
@SuperQ PTAL |
Hi team,
I have added a new feature to the
hwmon
collector that enables the monitoring of GPU clock frequencies, specificallysclk
(Shader Clock) andmclk
(Memory Clock).The
hwmon
collector now reads the following data from the/sys/class/hwmon
directory:and generate following metrics:
Please let me know if there are any questions or if further adjustments are needed.
Thank you!
closes:#3092