proposal: Update Created Timestamps syntax for OpenMetrics #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maniktherana
force-pushed
the
update-cts
branch
from
715ab7f to
55f3ad3
Compare
Signed-off-by: Manik Rana <manikrana54@gmail.com>
Signed-off-by: Manik Rana <manikrana54@gmail.com>
Signed-off-by: Manik Rana <manikrana54@gmail.com>
Signed-off-by: Manik Rana <manikrana54@gmail.com>
Maniktherana
force-pushed
the
update-cts
branch
from
70bd50a to
be917f1
Compare
Signed-off-by: Manik Rana <manikrana54@gmail.com>
Signed-off-by: Manik Rana <manikrana54@gmail.com>
Signed-off-by: Manik Rana <manikrana54@gmail.com>
Signed-off-by: Manik Rana <manikrana54@gmail.com>
Maniktherana
changed the title
Signed-off-by: Manik Rana <Manikrana54@gmail.com>
Signed-off-by: Manik Rana <Manikrana54@gmail.com>
ArthurSens
reviewed
Dec 17, 2024
proposals/2024-12-14_update-created-timestamps-for-openmetrics-text.md
Outdated
Show resolved
Hide resolved
proposals/2024-12-14_update-created-timestamps-for-openmetrics-text.md
Outdated
Show resolved
Hide resolved
proposals/2024-12-14_update-created-timestamps-for-openmetrics-text.md
Outdated
Show resolved
Hide resolved
proposals/2024-12-14_update-created-timestamps-for-openmetrics-text.md
Outdated
Show resolved
Hide resolved
proposals/2024-12-14_update-created-timestamps-for-openmetrics-text.md
Outdated
Show resolved
Hide resolved
proposals/2024-12-14_update-created-timestamps-for-openmetrics-text.md
Outdated
Show resolved
Hide resolved
proposals/2024-12-14_update-created-timestamps-for-openmetrics-text.md
Outdated
Show resolved
Hide resolved
proposals/2024-12-14_update-created-timestamps-for-openmetrics-text.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com> Signed-off-by: Manik Rana <Manikrana54@gmail.com>
Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com> Signed-off-by: Manik Rana <Manikrana54@gmail.com>
Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com> Signed-off-by: Manik Rana <Manikrana54@gmail.com>
I should use grammarly Co-authored-by: Arthur Silva Sens <arthursens2005@gmail.com> Signed-off-by: Manik Rana <Manikrana54@gmail.com>
Signed-off-by: Manik Rana <Manikrana54@gmail.com>
Signed-off-by: Manik Rana <Manikrana54@gmail.com>
Signed-off-by: Manik Rana <Manikrana54@gmail.com>
bwplotka
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Nice, I would go for this. Even in the event of we would do a significant change to the format following the prometheus/OpenMetrics#283 it might be still a relevant and valid direction for CT format.
Also, amazingly well written proposal, thanks for this!
proposals/2024-12-14_update-created-timestamps-for-openmetrics-text.md
Outdated
Show resolved
Hide resolved
proposals/2024-12-14_update-created-timestamps-for-openmetrics-text.md
Outdated
Show resolved
Hide resolved
| ``` | ||
| # HELP foo Counter with and without labels to certify CT is parsed for both cases | ||
| # TYPE foo counter | ||
| # CREATED 1520872607.123; {a="b"} 1520872607.123; {le="c"} 1520872621.123 |
There was a problem hiding this comment.
This is one option, but another option would be to do CREATED <ts> and then separate "group" when this changes. This is tricky because it in the past the group (metric family) should not duplicate. We try to challenge this in other discussions/proposals though: prometheus/OpenMetrics#280
There was a problem hiding this comment.
dont think I follow but are you saying each label within a metricfamily has its own # CREATED (+ unit and type)?
bwplotka
reviewed
Dec 18, 2024
Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: Manik Rana <Manikrana54@gmail.com>
Signed-off-by: Manik Rana <Manikrana54@gmail.com>
Signed-off-by: Manik Rana <Manikrana54@gmail.com>
Signed-off-by: Manik Rana <Manikrana54@gmail.com>
Signed-off-by: Manik Rana <Manikrana54@gmail.com>
|
just saw the tagged issue
This is something I overlooked and could be worth adding to the proposal |
dashpole
approved these changes
Jan 8, 2025
This was referenced Feb 13, 2025
|
Hello from the bug scrub! With two approvals, can we just merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a proposal to update the syntax of Created Timestamps in the OpenMetrics text exposition format.
Aims to address prometheus/prometheus#14823