Skip to content

chore: clean up golangci-lint configuration#629

Merged
pedro-stanaka merged 1 commit intoprometheus:masterfrom
mmorel-35:golangci-lint/clean-up
Aug 13, 2025
Merged

chore: clean up golangci-lint configuration#629
pedro-stanaka merged 1 commit intoprometheus:masterfrom
mmorel-35:golangci-lint/clean-up

Conversation

@mmorel-35
Copy link
Copy Markdown
Contributor

@mmorel-35 mmorel-35 commented Apr 25, 2025

Description

chore: clean up golangci-lint configuration

@mmorel-35
Copy link
Copy Markdown
Contributor Author

/cc @kakkoyun @SuperQ

@mmorel-35 mmorel-35 force-pushed the golangci-lint/clean-up branch from 9680104 to fbcff08 Compare April 25, 2025 08:11
Copy link
Copy Markdown
Contributor

@pedro-stanaka pedro-stanaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean up.

I have mixed feelings about this, though. I rather have more of a "semantic" order.

So I will defer to the other maintainers.

Copy link
Copy Markdown
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same comment:

prometheus/procfs#720 (review)

@matthiasr
Copy link
Copy Markdown
Contributor

Tbh I do not care or look at linter configuration unless it gives me trouble, I generally just accept whatever someone with an opinion set up. As such I have even less of an opinion than you @pedro-stanaka 😄

@mmorel-35 mmorel-35 force-pushed the golangci-lint/clean-up branch 3 times, most recently from 24bfbd4 to 57ad169 Compare August 1, 2025 21:04
@mmorel-35 mmorel-35 changed the title chore: clean up and sort golangci-lint configuration chore: clean up golangci-lint configuration Aug 1, 2025
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 force-pushed the golangci-lint/clean-up branch from 57ad169 to 0dbbd7e Compare August 1, 2025 21:11
@pedro-stanaka pedro-stanaka merged commit 144bc6b into prometheus:master Aug 13, 2025
4 checks passed
@mmorel-35 mmorel-35 deleted the golangci-lint/clean-up branch August 13, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants