Fix: Convert language names to lowercase before Shiki highlighting #403
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue where Shiki syntax highlighting failed when language names were provided in uppercase format (e.g., "JSON", "Python") instead of the expected lowercase format.
Problem
Previously, passing uppercase language names to the highlighting function would result in errors like:
This occurred because Shiki's
bundledLanguagesobject contains language keys in lowercase (e.g., "json", "python"), but the code was performing case-sensitive comparisons without normalization.Solution
Updated the
getHighlighterandhighlightfunctions insrc/lib/highlight.tsto normalize language names to lowercase before processing:codeToHtmlmethodBenefits
Example
Fixes #65.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.