refactor: unused code after migration from nextui

[billybonks]

Exploring refactoring this code as commented in #3825, after the migration nextui -> react + 8months of coding caused all this code to exist even though its not used. #1637

Best thing to do is to delete and move on. if it is used please let me know how and close this pr
preloaded data was originally used using what is now known as fetchId 2 years ago 4ebb21d

recentEvals is now loaded using fetchRecentEvals
defaultEvalId is now being set during one of the load sequances

I also cant see where this component is being used outside of src/app/src/pages/eval/page.tsx

Summary by Sourcery

Remove unused and deprecated code related to preloaded data and eval initialization from the Eval component

Enhancements:

• Simplify component interface by removing unused parameters

Chores:

• Remove deprecated props and state management for preloadedData, recentEvals, and defaultEvalId

[sourcery-ai]

Reviewer's Guide

This PR refactors the Eval component by removing several props (preloadedData, recentEvals, defaultEvalId) and their corresponding logic, which were identified as unused. The implementation involved deleting these props from the EvalOptions interface and the component's signature, removing the conditional logic block that handled preloadedData, and simplifying the initial state for recentEvals and defaultEvalId.

Sequence Diagram: Eval Component Initialization Flow After Refactor

sequenceDiagram
    participant E as EvalComponent
    Note over E: Component Initialization Sequence
    alt fetchId prop is provided
        E->>E: Initialize: Fetch data using fetchId
    else IS_RUNNING_LOCALLY is true
        E->>E: Initialize: Connect to local server websocket
    else No fetchId and not running locally
        E->>E: Initialize: Fetch recent file evaluations
    end
    Note over E: The initialization path using the 'preloadedData' prop has been removed.

Loading

Class Diagram: Changes to EvalOptions Interface and Eval Component

classDiagram
    class EvalOptions {
        <<Interface>>
        +fetchId: string | null
    }
    note for EvalOptions "Removed optional props:\n- preloadedData: SharedResults\n- recentEvals: ResultLightweightWithLabel[]\n- defaultEvalId: string"

    class Eval {
        <<FunctionComponent>>
        +props: EvalOptions
        -state recentEvals: ResultLightweightWithLabel[]
        -state defaultEvalId: string
        +useEffect_initialization(): void
    }
    note for Eval "Props are now defined by the simplified EvalOptions.\nState 'recentEvals' initialization changed (e.g., from 'recentEvalsProp || []' to '[]').\nState 'defaultEvalId' initialization changed (e.g., from 'defaultEvalIdProp || ...' to '').\nuseEffect_initialization() logic simplified by removing the 'preloadedData' handling branch."

    Eval ..> EvalOptions : "props defined by"

Loading

File-Level Changes

Change	Details	Files
Removed unused props from component definition.	Deleted preloadedData, recentEvals, and defaultEvalId from the EvalOptions interface. Removed preloadedData, recentEvalsProp, and defaultEvalIdProp from the Eval component's function signature.	src/app/src/pages/eval/components/Eval.tsx
Eliminated logic associated with preloadedData.	Deleted the conditional block that initialized component state using preloadedData within a useEffect hook. Removed preloadedData from a useEffect hook's dependency array.	src/app/src/pages/eval/components/Eval.tsx
Simplified initialization of component states.	The recentEvals state is now initialized directly with an empty array, removing reliance on the recentEvalsProp. The defaultEvalId state is now initialized directly with an empty string, removing reliance on defaultEvalIdProp or the recentEvals state during its own initialization.	src/app/src/pages/eval/components/Eval.tsx

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[gru-agent]

TestGru Assignment

Summary

Link	CommitId	Status	Reason
Detail	246b542	🚫 Skipped	No files need to be tested {"src/app/src/pages/eval/components/Eval.tsx":"File path does not match include patterns."}

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

[gru-agent]

TestGru Assignment

Summary

Link	CommitId	Status	Reason
Detail	246b542	🚫 Skipped	No files need to be tested {"src/app/src/pages/eval/components/Eval.tsx":"File path does not match include patterns."}

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

[billybonks]

this is the target #3902

[mldangelo]

Thanks for the contribution! The refactoring goals here have been achieved through other changes in main. Closing as stale.