KyberSwap Classic Adapter #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PierreMkt
reviewed
May 29, 2024
| uint112 vr1; | ||
| uint256 feeInPrecision; | ||
| if (sellToken < buyToken) { | ||
| (r0, r1, vr0, vr1, feeInPrecision) = pair.getTradeInfo(); |
There was a problem hiding this comment.
why not use TradeParams here ?
Comment on lines
+23
to
+25
| // Kyberswap handles arbirary amounts, but we limit the amount to 10x just | ||
| // in case | ||
| uint256 constant RESERVE_LIMIT_FACTOR = 10; |
There was a problem hiding this comment.
"just in case" of what?
There was a problem hiding this comment.
Idk why this is being used below to divide the reserves
Comment on lines
+79
to
+84
| ( | ||
| tradeParams.r0, | ||
| tradeParams.r1, | ||
| tradeParams.vr0, | ||
| tradeParams.vr1, | ||
| tradeParams.feeInPrecision |
There was a problem hiding this comment.
can you not abbreviate these attributes? will save people having to inspect the interface and the names are not so big
Comment on lines
+13
to
+19
| struct TradeParams { | ||
| uint112 r0; | ||
| uint112 r1; | ||
| uint112 vr0; | ||
| uint112 vr1; | ||
| uint256 feeInPrecision; | ||
| } |
There was a problem hiding this comment.
maybe TradePairAttributes is a better name?
Comment on lines
+184
to
+190
| /// @notice Executes a sell order on a given pool. | ||
| /// @param pair The pair to trade on. | ||
| /// @param sellToken The token being sold. | ||
| /// @param buyToken The token being bought. | ||
| /// @param amount The amount to be traded. | ||
| /// @return calculatedAmount The amount of tokens received. | ||
| function sell( |
There was a problem hiding this comment.
doenst inheritdoc work here?
Comment on lines
+64
to
+69
| function swap( | ||
| bytes32 poolId, | ||
| address sellToken, | ||
| address buyToken, | ||
| OrderSide side, | ||
| uint256 specifiedAmount |
Comment on lines
+259
to
+271
| /// @notice Given an input amount of an asset and pair reserves, returns the | ||
| /// maximum output amount of the other asset | ||
| /// @param amountIn The amount of the token being sold. | ||
| /// @param vReserveIn The virtual reserve of the token being sold. | ||
| /// @param vReserveOut The virtual reserve of the token being bought. | ||
| /// @param feeInPrecision Fee in PRECISION points | ||
| /// @return amountOut The amount of tokens received. | ||
| function getAmountOut( | ||
| uint256 amountIn, | ||
| uint256 vReserveIn, | ||
| uint256 vReserveOut, | ||
| uint256 feeInPrecision | ||
| ) internal pure returns (uint256 amountOut) { |
There was a problem hiding this comment.
what is this used for?
tvinagre
force-pushed
the
feature/kyberswap-classic-adapter
branch
from
245d799 to
bdfbff4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.