Support Node >= v22 #1540
Merged
Support Node >= v22 #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the import statements for JSON modules to use 'with' instead of 'assert'. This ensures compatibility with the latest module syntax standards and helps maintain consistency across the codebase.
hckhanh
requested review from
forgetso,
goastler and
HughParry
as code owners
|
I have tested with Node 20, It can run smoothly. |
|
HeY @hckhanh thanks very much for the PR! We'll get this in very soon. |
|
Hey @hckhanh we usually PR into the |
|
Sure I will do it |
|
@hckhanh thanks so much! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address #1539
This change updates the import statements for JSON modules to use 'with' instead of 'assert'. This ensures compatibility with the latest module syntax standards and helps maintain consistency across the codebase.