Skip to content

Remove contract 2 + Code Split #1610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 13, 2025
Merged

Remove contract 2 + Code Split #1610

merged 9 commits into from
Jan 13, 2025

Conversation

forgetso
Copy link
Member

@forgetso forgetso commented Jan 11, 2025

  • removes most of the functions in the contract package and move to a new package called keyring
  • adds dynamic imports in a load of places for better code splitting
  • removes the canvas stuff from the account generator

New Bundle

dist/bundle/procaptcha.bundle.js            0.12 kB │ gzip:   0.12 kB
dist/bundle/asU8a-t99hafrf.js               0.17 kB │ gzip:   0.16 kB
dist/bundle/spread-DEmVz7RJ.js              0.28 kB │ gzip:   0.19 kB
dist/bundle/Signer-DP9drQ55.js              0.33 kB │ gzip:   0.18 kB
dist/bundle/index-QVME9Prx.js               1.44 kB │ gzip:   0.71 kB
dist/bundle/index-DN4Tp-kg.js               2.13 kB │ gzip:   0.90 kB
dist/bundle/sha256-Dm0BaA-M.js              5.02 kB │ gzip:   2.13 kB
dist/bundle/ProcaptchaWidget-RaP21-vz.js    6.14 kB │ gzip:   2.33 kB
dist/bundle/Checkbox-Be1FZQiE.js           20.97 kB │ gzip:   6.53 kB
dist/bundle/ProcaptchaWidget-DdESN6E2.js   23.10 kB │ gzip:   7.31 kB
dist/bundle/bip39-tMDHmkGA.js              23.38 kB │ gzip:  11.11 kB
dist/bundle/fp.esm-DIqXhnRe.js             48.48 kB │ gzip:  16.72 kB
dist/bundle/index-d40l5s4z.js              68.46 kB │ gzip:  28.19 kB
dist/bundle/index-DFV7ZmZI.js             232.38 kB │ gzip:  62.74 kB
dist/bundle/hash-DLJ3jCRq.js              260.68 kB │ gzip: 182.21 kB
dist/bundle/index-BXmNlL-m.js             597.12 kB │ gzip: 156.32 kB

image

Old Bundle

dist/bundle/procaptcha.bundle.js                                              0.12 kB │ gzip:   0.12 kB
dist/bundle/ProcaptchaWidget-C2pXE0yN.js                                      6.04 kB │ gzip:   2.30 kB
dist/bundle/ProcaptchaWidget-CfFn3hbN.js                                     22.92 kB │ gzip:   7.26 kB
dist/bundle/Checkbox-CQpUvSn8.js                                             22.94 kB │ gzip:   7.30 kB
dist/bundle/index-CQh9ivYn.js                                             1,245.09 kB │ gzip: 458.99 kB

image

@forgetso forgetso changed the title Remove contract 2 Remove contract 2 + Code Split Jan 11, 2025
@goastler
Copy link
Member

goastler commented Jan 13, 2025

removes the canvas stuff from the account generator

isn't this needed?

@forgetso forgetso merged commit 6ed0640 into staging Jan 13, 2025
4 checks passed
@forgetso forgetso deleted the remove-contract-2 branch January 13, 2025 09:36
@prosoponator prosoponator mentioned this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants