Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --max-warnings [int] option #57

Merged

Conversation

florblue
Copy link
Contributor

@florblue florblue commented Aug 30, 2018

Description

It was added --max-warnings [int] option: Number of warnings to trigger nonzero exit code.

It resolves issue #56.

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update
  • Existing unit tests pass locally with my changes

@coveralls
Copy link

coveralls commented Aug 30, 2018

Coverage Status

Coverage remained the same at 99.657% when pulling 6fdefd6 on Cambalab:add-contribution-max-warnings-issue#56 into 2263ccb on protofire:master.

@florblue florblue changed the title Add --max-warnings [int] option: Number of warnings to trigger nonzer… Add --max-warnings [int] option Aug 30, 2018
Copy link
Contributor

@fvictorio fvictorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the merge conflicts.

@fvictorio
Copy link
Contributor

After the merge, using -q breaks the --max-warnings option. I understand -q as hiding the warnings in the report, not removing them altogether, so I think the two options should work together.

@fvictorio fvictorio merged commit 21da46d into protofire:master Sep 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants